🌐 AI搜索 & 代理 主页
Delete `//chrome/services/qrcode_generator`.

After go/rusty-qr-code-generator we no longer need a separate service
that delegates QR code generation to a separate process.  Therefore this
CL deletes the `//chrome/services/qrcode_generator` directory.

* `qr_code_generator_pixeltest.cc` has been moved to
  `//chrome/browser/sharing` (as I am not sure if pixel tests are
  supported for `components_browsertests` - this has been discussed in
  https://crrev.com/c/5278872/8#message-5b43795fe4019875ebb87e19e95b49e08947133b).
* Code that draws a QR code into a `SkBitmap` has been moved from
  `//chrome/services/qrcode_generator/qrcode_generator_service_impl.*`
  to `//components/qr_code_generator/bitmap_generator.*`.
* `qrcode_generator.mojom` has been deleted:
    * Bitmap style enums (e.g. `LocatorStyle`) have been moved into
      `//components/qr_code_generator/bitmap_generator.h`
    * Error codes have been moved into
      `//components/qr_code_generator/qr_code_generator.h`
    * Fields of `GenerateQRCodeRequest` have been "splat" into
      parameters of the new `GenerateBitmap` function
    * `GenerateQRCodeResponse` has been replaced with a new
      `QRImage` struct plus `base::expected<QRImage, Error>`
* `QRImageGenerator` class has been deleted and its method
  has been refectored:
    * The method became a free function
    * The result is now returned directly instead of via a callback

This CL is quite big - I appologize.  Splitting this CL into smaller
pieces is a bit difficult, mostly because it seems hard to defining some
types in `.mojom` and some in `.h`.

Bug: 40263739
Change-Id: I39db6f56ad4138d8169e64fc715c10adfc32ca0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278872
Reviewed-by: Gavin Williams <gavinwill@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1261280}
44 files changed
tree: b9af8c710db4bb84276d9407de329d0412829018
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.