| commit | a2be834619701017dfcb830cc5b0b6522f4d52cf | [log] [tgz] |
|---|---|---|
| author | Lukasz Anforowicz <lukasza@chromium.org> | Thu Feb 15 20:49:12 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Feb 15 20:49:12 2024 |
| tree | b9af8c710db4bb84276d9407de329d0412829018 | |
| parent | 23d3a96370c740a266a917ffe252a5a4ea01eb08 [diff] |
Delete `//chrome/services/qrcode_generator`. After go/rusty-qr-code-generator we no longer need a separate service that delegates QR code generation to a separate process. Therefore this CL deletes the `//chrome/services/qrcode_generator` directory. * `qr_code_generator_pixeltest.cc` has been moved to `//chrome/browser/sharing` (as I am not sure if pixel tests are supported for `components_browsertests` - this has been discussed in https://crrev.com/c/5278872/8#message-5b43795fe4019875ebb87e19e95b49e08947133b). * Code that draws a QR code into a `SkBitmap` has been moved from `//chrome/services/qrcode_generator/qrcode_generator_service_impl.*` to `//components/qr_code_generator/bitmap_generator.*`. * `qrcode_generator.mojom` has been deleted: * Bitmap style enums (e.g. `LocatorStyle`) have been moved into `//components/qr_code_generator/bitmap_generator.h` * Error codes have been moved into `//components/qr_code_generator/qr_code_generator.h` * Fields of `GenerateQRCodeRequest` have been "splat" into parameters of the new `GenerateBitmap` function * `GenerateQRCodeResponse` has been replaced with a new `QRImage` struct plus `base::expected<QRImage, Error>` * `QRImageGenerator` class has been deleted and its method has been refectored: * The method became a free function * The result is now returned directly instead of via a callback This CL is quite big - I appologize. Splitting this CL into smaller pieces is a bit difficult, mostly because it seems hard to defining some types in `.mojom` and some in `.h`. Bug: 40263739 Change-Id: I39db6f56ad4138d8169e64fc715c10adfc32ca0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5278872 Reviewed-by: Gavin Williams <gavinwill@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Owners-Override: danakj <danakj@chromium.org> Reviewed-by: Robert Phillips <robertphillips@google.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/main@{#1261280}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.