| commit | ed4b9377d003cb368a01be249b82892cf3814103 | [log] [tgz] |
|---|---|---|
| author | Jens Johansen <jensj@google.com> | Mon Jun 03 11:00:09 2024 |
| committer | Commit Queue <dart-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 03 11:00:09 2024 |
| tree | deda237288e0343f874c3c57f1cb8087df14efba | |
| parent | 4ff851e5b21fed80ada99fd88bec4173cfb9e4ed [diff] |
[io/socket_read] Fix `available` bug when limit of aggregated read bytes goes into effect In 7fa9b814d28f032163ba51e56aedcb5d0c638cd3 (https://dart-review.googlesource.com/c/sdk/+/369141) a limit was introduced to prevent OOM. It however introduced a bug where `available` would be out of sync (> 0 when it should be 0) causing issues - seemingly an infinite loop where it continues trying to read even though no data is available - and e.g. the weekly bot timed out after 12 hours because stuff didn't work. (I think the issue is `stopRead()` returning false, but isn't sure). This CL fixes the issue by updating the field before the possible break. TEST=Hopefully a test will be added in a follow-up. Change-Id: I722c8868fd7354fc9403e8d2f387914c3fab884a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369243 Commit-Queue: Jens Johansen <jensj@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Dart is:
Approachable: Develop with a strongly typed programming language that is consistent, concise, and offers modern language features like null safety and patterns.
Portable: Compile to ARM, x64, or RISC-V machine code for mobile, desktop, and backend. Compile to JavaScript or WebAssembly for the web.
Productive: Make changes iteratively: use hot reload to see the result instantly in your running app. Diagnose app issues using DevTools.
Dart's flexible compiler technology lets you run Dart code in different ways, depending on your target platform and goals:
Dart Native: For programs targeting devices (mobile, desktop, server, and more), Dart Native includes both a Dart VM with JIT (just-in-time) compilation and an AOT (ahead-of-time) compiler for producing machine code.
Dart Web: For programs targeting the web, Dart Web includes both a development time compiler (dartdevc) and a production time compiler (dart2js).
Dart is free and open source.
See LICENSE and PATENT_GRANT.
Visit dart.dev to learn more about the language, tools, and to find codelabs.
Browse pub.dev for more packages and libraries contributed by the community and the Dart team.
Our API reference documentation is published at api.dart.dev, based on the stable release. (We also publish docs from our beta and dev channels, as well as from the primary development branch).
If you want to build Dart yourself, here is a guide to getting the source, preparing your machine to build the SDK, and building.
There are more documents in our repo at docs.
The easiest way to contribute to Dart is to file issues.
You can also contribute patches, as described in Contributing.
Future plans for Dart are included in the combined Dart and Flutter roadmap on the Flutter wiki.