Fix dependencies, error handling, and package validation #26525
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng, and scenario conditions Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
…ageManager Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Apply changes based on review comments
Apply review comments from PR #26504: fix dependencies, error handling, and package validation
Nov 24, 2025
TravisEz13
approved these changes
Nov 24, 2025
TravisEz13
reviewed
Nov 25, 2025
tools/packaging/packaging.psm1
Outdated
|
|
||
| # Build the package using dpkg-deb | ||
| $debFileName = "${Name}_${Version}-${Iteration}_${HostArchitecture}.deb" | ||
| $debFileName = "${Name}_${Version}-${Iteration}.deb_${HostArchitecture}.deb" |
Member
There was a problem hiding this comment.
@copilot This created an invalid file name
WARNING: powershell_7.6.0-preview.6-1.deb.deb_amd64.deb is not a valid DEB package name
Error: [-] Linux Package Name Validation.DEB Package Names.Should have valid DEB package names 59ms (58ms|2ms)
Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Addresses review comments from PR #26504 to fix DEB package generation, dependency checking, and build scenario conditions.
PR Context
The original PR #26504 replaced
fpmwith nativedpkg-debfor DEB package generation. This PR fixes issues identified in code review:Dependency Management
New-NativeDeb: Omit emptyDepends:field when no dependencies specified (prevents invalid control file)Test-Dependencies: Add platform-specific checks fordpkg-deb(Debian) andrpmbuild(RPM systems), not just MarinerPackage Validation
name_version-iteration.deb_arch.deb(wasname_version-iteration_arch.deb)~rc.1) and variable iteration (-\dvs-1) to match pipeline validationError Handling
Get-Errorand rethrow exceptions (was silently swallowing errors)Build System
'All'option in all 4 package-related checks (Ubuntu/Debian, RedHat/Mariner, SUSE, Windows WiX)Write-LogGroupwithWrite-LogGroupStart/Write-LogGroupEndPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.