[squash] Test of changed size in the lookup mehtod

kralka · kralka · commit 71066cee1c60 · 2025-10-28T08:19:43.000+01:00
diff --git a/vm/src/dict_inner.rs b/vm/src/dict_inner.rs
@@ -574,6 +574,7 @@ impl<T: Clone> Dict<T> {
     ) -> PyResult<LookupResult> {
         let mut idxs = None;
         let mut free_slot = None;
+        let original_size = self.size();
         let ret = 'outer: loop {
             let (entry_key, ret) = {
                 let inner = lock.take().unwrap_or_else(|| self.read());
@@ -585,7 +586,7 @@ impl<T: Clone> Dict<T> {
                     let index_entry = match inner.indices.get(index_index) {
                         None => {
                             // Dictionary was modified under our hands, see TestMethodsMutating.
-                            continue 'outer;
+                            return Err(vm.new_runtime_error("set changed size during iteration"));
                         }
                         Some(v) => *v,
                     };
@@ -600,6 +601,11 @@ impl<T: Clone> Dict<T> {
                                 Some(free) => (IndexEntry::DUMMY, free),
                                 None => (IndexEntry::FREE, index_index),
                             };
+                            if self.has_changed_size(&original_size) {
+                                return Err(
+                                    vm.new_runtime_error("set changed size during iteration")
+                                );
+                            }
                             return Ok(idxs);
                         }
                         idx => {
@@ -631,6 +637,9 @@ impl<T: Clone> Dict<T> {
 
             // warn!("Perturb value: {}", i);
         };
+        if self.has_changed_size(&original_size) {
+            return Err(vm.new_runtime_error("set changed size during iteration"));
+        }
         Ok(ret)
     }
 
