PyBool downcastable_from

youknowone · youknowone · commit 8db2660ae634 · 2025-12-02T14:20:27.000+09:00
diff --git a/crates/vm/src/builtins/bool.rs b/crates/vm/src/builtins/bool.rs
@@ -3,7 +3,7 @@ use crate::common::format::FormatSpec;
 use crate::{
     AsObject, Context, Py, PyObject, PyObjectRef, PyPayload, PyResult, TryFromBorrowedObject,
     VirtualMachine,
-    class::PyClassImpl,
+    class::{PyClassImpl, StaticType},
     convert::{IntoPyException, ToPyObject, ToPyResult},
     function::OptionalArg,
     identifier,
@@ -22,10 +22,15 @@ impl ToPyObject for bool {
 
 impl<'a> TryFromBorrowedObject<'a> for bool {
     fn try_from_borrowed_object(vm: &VirtualMachine, obj: &'a PyObject) -> PyResult<Self> {
-        if obj.fast_isinstance(vm.ctx.types.int_type) {
-            Ok(get_value(obj))
-        } else {
-            Err(vm.new_type_error(format!("Expected type bool, not {}", obj.class().name())))
+        // Python takes integers as a legit bool value
+        match obj.downcast_ref::<PyInt>() {
+            Some(int_obj) => {
+                let int_val = int_obj.as_bigint();
+                Ok(!int_val.is_zero())
+            }
+            None => {
+                Err(vm.new_type_error(format!("Expected type bool, not {}", obj.class().name())))
+            }
         }
     }
 }
@@ -93,6 +98,10 @@ impl PyPayload for PyBool {
         std::any::TypeId::of::<PyInt>()
     }
 
+    fn downcastable_from(obj: &PyObject) -> bool {
+        obj.class().is(PyBool::static_type())
+    }
+
     fn try_downcast_from(obj: &PyObject, vm: &VirtualMachine) -> PyResult<()> {
         if obj.class().is(vm.ctx.types.bool_type) {
             return Ok(());
