[TASK] Adapt for upcoming Symfony 5.3 command tag properties

bnf · bnf · commit 1cfb4efabb1b · 2021-02-04T09:55:36.000+01:00
With the Symfony PR symfony/symfony#39851 new depndency injection console.command tag properties are supported, which allow to inject the description and the hidden state into console commands. In order to maintain a consistent console.command DI tag syntax between Symfony and TYPO3 core, we now add forward compatibility for this change. Releases: master, 10.4 Resolves: #93425 Related: #93174 Change-Id: Ie5dac65deaede2099f2d337466295bd2815ce918 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67600 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benjamin Franzke <bfr@qbus.de> Reviewed-by: Benjamin Franzke <bfr@qbus.de>
diff --git a/Classes/DependencyInjection/ConsoleCommandPass.php b/Classes/DependencyInjection/ConsoleCommandPass.php
@@ -52,11 +52,15 @@ public function process(ContainerBuilder $container)
         foreach ($container->findTaggedServiceIds($this->tagName) as $serviceName => $tags) {
             $commandServiceDefinition = $container->findDefinition($serviceName)->setPublic(true);
             $commandName = null;
+            $description = null;
+            $hidden = false;
             $aliases = [];
             foreach ($tags as $attributes) {
                 if (!isset($attributes['command'])) {
                     continue;
                 }
+                $description = $attributes['description'] ?? $description;
+                $hidden = (bool)($attributes['hidden'] ?? $hidden);
                 $commandRegistryDefinition->addMethodCall('addLazyCommand', [
                     $attributes['command'],
                     $serviceName,
@@ -70,6 +74,12 @@ public function process(ContainerBuilder $container)
                 }
             }
             $commandServiceDefinition->addMethodCall('setName', [$commandName]);
+            if ($description) {
+                $commandServiceDefinition->addMethodCall('setDescription', [$description]);
+            }
+            if ($hidden) {
+                $commandServiceDefinition->addMethodCall('setHidden', [true]);
+            }
             if ($aliases) {
                 $commandServiceDefinition->addMethodCall('setAliases', [$aliases]);
             }
