merge: Edit Perfect{Square, Cube} (#1071)

Rudxain · web-flow · commit 979046897dd6 · 2022-08-12T23:14:25.000+05:30
* Make `PerfectCube` more correct and readable

* Add negative and Infinity tests

* Fixed comment formatting

* Realized BigInt support is unnecessary

The algorithm would be exactly the same, so there's no added educational value

* Update PerfectCube.js

* Remove space

* Update PerfectCube.js

Now `isInt` is replaced by `isFinite`, because `isInt` is a redundant check

* Update PerfectCube.js

Remove dot

* Parity between `PerfectSquare` and `PerfectCube`

* Update PerfectSquare.test.js

Fixed the old copy-paste error that said "cube" instead of "square". And added `Infinity` test
diff --git a/Maths/PerfectCube.js b/Maths/PerfectCube.js
@@ -2,8 +2,9 @@
  * Author: dephraiim
  * License: GPL-3.0 or later
  *
+ * This uses `round` instead of `floor` or `trunc`, to guard against potential `cbrt` accuracy errors
  */
 
-const perfectCube = (num) => Math.round(num ** (1 / 3)) ** 3 === num
+const perfectCube = (num) => Number.isFinite(num) && Math.round(Math.cbrt(num)) ** 3 === num
 
 export { perfectCube }
diff --git a/Maths/PerfectSquare.js b/Maths/PerfectSquare.js
@@ -2,8 +2,9 @@
  * Author: dephraiim
  * License: GPL-3.0 or later
  *
+ * This uses `round` instead of `floor` or `trunc`, to guard against potential `sqrt` accuracy errors
  */
 
-const perfectSquare = (num) => Math.sqrt(num) ** 2 === num
+const perfectSquare = (num) => Number.isFinite(num) && Math.round(Math.sqrt(num)) ** 2 === num
 
 export { perfectSquare }
diff --git a/Maths/test/PerfectCube.test.js b/Maths/test/PerfectCube.test.js
@@ -3,8 +3,10 @@ import { perfectCube } from '../PerfectCube'
 describe('PerfectCube', () => {
   it('should return true for a perfect cube', () => {
     expect(perfectCube(125)).toBeTruthy()
+    expect(perfectCube(-125)).toBeTruthy()
   })
   it('should return false for a non perfect cube', () => {
     expect(perfectCube(100)).toBeFalsy()
+    expect(perfectCube(Infinity)).toBeFalsy()
   })
 })
diff --git a/Maths/test/PerfectSquare.test.js b/Maths/test/PerfectSquare.test.js
@@ -1,10 +1,11 @@
 import { perfectSquare } from '../PerfectSquare'
 
 describe('PerfectSquare', () => {
-  it('should return true for a perfect cube', () => {
+  it('should return true for a perfect square', () => {
     expect(perfectSquare(16)).toBeTruthy()
   })
-  it('should return false for a non perfect cube', () => {
+  it('should return false for a non perfect square', () => {
     expect(perfectSquare(10)).toBeFalsy()
+    expect(perfectSquare(Infinity)).toBeFalsy()
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,9 @@`
`2`	`2`	`* Author: dephraiim`
`3`	`3`	`* License: GPL-3.0 or later`
`4`	`4`	`*`
	`5`	+ * This uses `round` instead of `floor` or `trunc`, to guard against potential `cbrt` accuracy errors
`5`	`6`	`*/`
`6`	`7`
`7`		`-const perfectCube = (num) => Math.round(num (1 / 3)) 3 === num`
	`8`	`+const perfectCube = (num) => Number.isFinite(num) && Math.round(Math.cbrt(num)) ** 3 === num`
`8`	`9`
`9`	`10`	`export { perfectCube }`