chore: fix linting for PR #3913 (#3939)

tmorehouse · web-flow · commit 3d60ca4886e7 · 2019-08-24T13:58:46.000-03:00
diff --git a/docs/markdown/reference/images/README.md b/docs/markdown/reference/images/README.md
@@ -72,7 +72,7 @@ module.exports = {
       .use('vue-loader')
       .loader('vue-loader')
       .tap(options => {
-        options['transformAssetUrls'] = {
+        options.transformAssetUrls = {
           img: 'src',
           image: 'xlink:href',
           'b-img': 'src',
diff --git a/docs/plugins/play.js b/docs/plugins/play.js
@@ -87,12 +87,12 @@ const destroyVM = (name, vm) => {
 }
 
 const processExamples = (el, binding, vnode, oldVnode) => {
-  if (vnode.context.$options['beforeDestroy']) {
-    vnode.context.$options['beforeDestroy'] = []
-      .concat(vnode.context.$options['beforeDestroy'])
+  if (vnode.context.$options.beforeDestroy) {
+    vnode.context.$options.beforeDestroy = []
+      .concat(vnode.context.$options.beforeDestroy)
       .filter(h => h)
   } else {
-    vnode.context.$options['beforeDestroy'] = []
+    vnode.context.$options.beforeDestroy = []
   }
 
   // Get all code-snippets
@@ -122,7 +122,7 @@ const processExamples = (el, binding, vnode, oldVnode) => {
     let vm = createVM(name, pre, vnode)
 
     // Ensure we destroy the VM when parent is destroyed
-    vnode.context.$options['beforeDestroy'].push(() => destroyVM(name, vm))
+    vnode.context.$options.beforeDestroy.push(() => destroyVM(name, vm))
 
     // Enable live edit on double click
     pre.ondblclick = async () => {
diff --git a/src/components/button/button.js b/src/components/button/button.js
@@ -115,8 +115,8 @@ const computeAttrs = (props, data) => {
   const link = isLink(props)
   const toggle = isToggle(props)
   const nonStdTag = isNonStandardTag(props)
-  const role = data.attrs && data.attrs['role'] ? data.attrs['role'] : null
-  let tabindex = data.attrs ? data.attrs['tabindex'] : null
+  const role = data.attrs && data.attrs.role ? data.attrs.role : null
+  let tabindex = data.attrs ? data.attrs.tabindex : null
   if (nonStdTag) {
     tabindex = '0'
   }
diff --git a/src/components/form-group/form-group.js b/src/components/form-group/form-group.js
@@ -293,22 +293,29 @@ export const BFormGroup = {
       return keys(this.labelColProps).length > 0
     },
     labelId() {
-      return this.$slots['label'] || this.label ? this.safeId('_BV_label_') : null
+      return this.hasNormalizedSlot('label') || this.label ? this.safeId('_BV_label_') : null
     },
     descriptionId() {
-      return this.$slots['description'] || this.description ? this.safeId('_BV_description_') : null
+      return this.hasNormalizedSlot('description') || this.description
+        ? this.safeId('_BV_description_')
+        : null
     },
     hasInvalidFeedback() {
       // Used for computing aria-describedby
-      const $slots = this.$slots
-      return this.computedState === false && ($slots['invalid-feedback'] || this.invalidFeedback)
+      return (
+        this.computedState === false &&
+        (this.hasNormalizedSlot('invalid-feedback') || this.invalidFeedback)
+      )
     },
     invalidFeedbackId() {
       return this.hasInvalidFeedback ? this.safeId('_BV_feedback_invalid_') : null
     },
     hasValidFeedback() {
       // Used for computing aria-describedby
-      return this.computedState === true && (this.$slots['valid-feedback'] || this.validFeedback)
+      return (
+        this.computedState === true &&
+        (this.hasNormalizedSlot('valid-feedback') || this.validFeedback)
+      )
     },
     validFeedbackId() {
       return this.hasValidFeedback ? this.safeId('_BV_feedback_valid_') : null
diff --git a/src/utils/loose-equal.spec.js b/src/utils/loose-equal.spec.js
@@ -168,8 +168,10 @@ describe('utils/looseEqual', () => {
   it('compares null and undefined values correctly', () => {
     expect(looseEqual(null, null)).toBe(true)
     expect(looseEqual(undefined, undefined)).toBe(true)
+    // eslint-disable-next-line no-void
     expect(looseEqual(void 0, undefined)).toBe(true)
     expect(looseEqual(null, undefined)).toBe(false)
+    // eslint-disable-next-line no-void
     expect(looseEqual(null, void 0)).toBe(false)
     expect(looseEqual(null, '')).toBe(false)
     expect(looseEqual(null, false)).toBe(false)
