fix(v-b-toggle): don't override role if element has a role assigned (#3889)

tmorehouse · web-flow · commit 5d155badd671 · 2019-08-14T20:22:16.000-03:00
diff --git a/src/directives/toggle/toggle.js b/src/directives/toggle/toggle.js
@@ -1,5 +1,5 @@
 import looseEqual from '../../utils/loose-equal'
-import { addClass, removeAttr, removeClass, setAttr } from '../../utils/dom'
+import { addClass, hasAttr, removeAttr, removeClass, setAttr } from '../../utils/dom'
 import { isBrowser } from '../../utils/env'
 import { bindTargets, getTargets, unbindTargets } from '../../utils/target'
 
@@ -91,7 +91,7 @@ export const VBToggle = {
       setAttr(el, 'aria-controls', el[BV_TOGGLE_CONTROLS])
       setAttr(el, 'aria-expanded', 'false')
       // If element is not a button, we add `role="button"` for accessibility
-      if (el.tagName !== 'BUTTON') {
+      if (el.tagName !== 'BUTTON' && !hasAttr(el, 'role')) {
         setAttr(el, 'role', 'button')
       }
 
