You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using IntersectionObserver directly, switch to the private v-b-visible directive
If we assume the user has added a polyfill for IntersectionObserver we can further reduce the size of the code by removing all the fallback window scroll/transition listeners.
If IntersectionObserver is not found, we just always force show the image (always non-lazy)
To Do:
Update docs
Update tests (Intersection Observer is not supported in JSDOM, so need a mock implementation)
PR checklist
What kind of change does this PR introduce? (check at least one)
Bugfix
Feature
Enhancement
ARIA accessibility
Documentation update
Other (please describe) code refactor
Does this PR introduce a breaking change? (check one)
No
Yes (please describe)
If IntersectionObserver support is not found (either natively or via polyfill), then the image will always be shown (non-lazy, and regardless of the show prop state)
The PR fulfills these requirements:
It's submitted to the dev branch, not the master branch
When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.
If new features/enhancement/fixes are added or changed:
Includes documentation updates (including updating the component's package.json for slot and event changes)
Includes any needed TypeScript declaration file updates
New/updated tests are included and passing (if required)
Existing test suites are passing
The changes have not impacted the functionality of other components or directives
ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:
A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
tmorehouse
changed the title
chore(b-img-lazy): switch IntersectionObserver to use private v-b-visible directive
feat(b-img-lazy): switch IntersectionObserver to use private v-b-visible directive
Aug 29, 2019
It appears that Vue-test-utils doesn't unbind a directive if the directive is conditionally removed from the element. It only calls unbind if the node is destroyed. Although Vue itself does properly unbind a directive if it is removed from the render.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the PR
Rather than using
IntersectionObserverdirectly, switch to the privatev-b-visibledirectiveIf we assume the user has added a polyfill for
IntersectionObserverwe can further reduce the size of the code by removing all the fallback window scroll/transition listeners.If
IntersectionObserveris not found, we just always force show the image (always non-lazy)To Do:
PR checklist
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If
IntersectionObserversupport is not found (either natively or via polyfill), then the image will always be shown (non-lazy, and regardless of the show prop state)The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples, fix typos,chore: fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages.If new features/enhancement/fixes are added or changed:
package.jsonfor slot and event changes)If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: