🌐 AI搜索 & 代理 主页
Skip to content

fix(b-table): handle filter as an object when using providers and prevent duplicate provider calls on mount (fixes #4065) #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmorehouse merged 51 commits into from
Sep 11, 2019
Merged

fix(b-table): handle filter as an object when using providers and prevent duplicate provider calls on mount (fixes #4065) #4068

tmorehouse merged 51 commits into from
Sep 11, 2019

Conversation

@tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Sep 10, 2019 •
edited
Loading

Describe the PR

Updates the filter watcher to be deep to check for changes in properties when an object is passed

Fixes #4065

Also fixes #4065 (comment) (duplicate provider calls on mount)

Closes #4067 (replaced by this PR)

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, fix typos, chore: fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@tmorehouse tmorehouse changed the title fix(b-table): handle filter as an object when using providers fix(b-table): handle filter as an object when using providers (fixes #4065) Sep 10, 2019
@codecov
Copy link

codecov bot commented Sep 10, 2019 •
edited
Loading

Codecov Report

Merging #4068 into dev will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4068      +/-   ##
==========================================
- Coverage   99.86%   99.86%   -0.01%     
==========================================
  Files         238      238              
  Lines        4475     4470       -5     
  Branches     1260     1260              
==========================================
- Hits         4469     4464       -5     
  Misses          5        5              
  Partials        1        1
Impacted Files Coverage Δ
src/components/table/helpers/mixin-filtering.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f95ef1...0b40b69. Read the comment docs.

@tmorehouse tmorehouse mentioned this pull request Sep 10, 2019
Closed
@tmorehouse tmorehouse marked this pull request as ready for review September 10, 2019 16:36
@tmorehouse tmorehouse mentioned this pull request Sep 10, 2019
Closed
19 tasks
@tmorehouse tmorehouse changed the title fix(b-table): handle filter as an object when using providers (fixes #4065) fix(b-table): handle filter as an object when using providers and prevent duplicate provider calls on mount (fixes #4065) Sep 11, 2019
@tmorehouse tmorehouse added the PR: Patch Requires patch version bump label Sep 11, 2019
@tmorehouse tmorehouse merged commit 9ddd115 into dev Sep 11, 2019
@tmorehouse tmorehouse deleted the issue/4065 branch September 11, 2019 15:46
@tmorehouse tmorehouse mentioned this pull request Sep 12, 2019
Closed
This was referenced Sep 22, 2019
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 1, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 21, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees

No one assigned

Labels

PR: Patch Requires patch version bump Type: Fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

b-table: filter as object not reactive anymore when using items provider

3 participants

@tmorehouse @jacobmllr95