🌐 AI搜索 & 代理 主页
Skip to content

feat(b-modal): add ignore-enforce-focus-selector prop (closes #4537) #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacobmllr95 merged 12 commits into from
Jan 31, 2020
Merged

feat(b-modal): add ignore-enforce-focus-selector prop (closes #4537) #4702

jacobmllr95 merged 12 commits into from
Jan 31, 2020

Conversation

@jacobmllr95
Copy link
Member

@jacobmllr95 jacobmllr95 commented Jan 30, 2020 •
edited by tmorehouse
Loading

Describe the PR

This PR adds a new ignore-enforce-focus-selector prop for the <b-modal> component.

Closes #4537.
Replaces #4538.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@jacobmllr95 jacobmllr95 added Type: Feature PR: Minor Requires minor version bump labels Jan 30, 2020
@codecov
Copy link

codecov bot commented Jan 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (dev@6c82b36). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev    #4702   +/-   ##
======================================
  Coverage       ?   99.92%           
======================================
  Files          ?      253           
  Lines          ?     5269           
  Branches       ?     1399           
======================================
  Hits           ?     5265           
  Misses         ?        3           
  Partials       ?        1
Impacted Files Coverage Δ
src/components/modal/modal.js 99.59% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c82b36...f70ed7d. Read the comment docs.

tmorehouse
tmorehouse reviewed Jan 31, 2020
View reviewed changes
tmorehouse
tmorehouse reviewed Jan 31, 2020
View reviewed changes
@jacobmllr95 jacobmllr95 changed the title feat(b-modal): add ignoreEnforceFocusSelector prop (closes #4537) feat(b-modal): add ignore-enforce-focus-selector prop (closes #4537) Jan 31, 2020
@tmorehouse
Copy link
Member

tmorehouse commented Jan 31, 2020

should we include a simple (non-live) example for, say TinyMCE editor? basically mentioning the suggested value(s) when using TinyMCE?

tmorehouse
tmorehouse reviewed Jan 31, 2020
View reviewed changes
@jacobmllr95
Copy link
Member Author

jacobmllr95 commented Jan 31, 2020

should we include a simple (non-live) example for, say TinyMCE editor? basically mentioning the suggested value(s) when using TinyMCE?

What about a CodeSandbox live example?

@tmorehouse
Copy link
Member

tmorehouse commented Jan 31, 2020

I think just a simple mention of setting the selector to the ones for TinyMCE, rather than a full example.

Basically another short paragraph under the enforce focus section of the docs.

@jacobmllr95 jacobmllr95 mentioned this pull request Jan 31, 2020
Closed
20 tasks
@jacobmllr95 jacobmllr95 merged commit c3ac992 into dev Jan 31, 2020
@jacobmllr95 jacobmllr95 deleted the feat-add-ignore-enforce-focus-selector-prop branch January 31, 2020 20:32
This was referenced Feb 24, 2020
Open
Merged
This was referenced Feb 25, 2020
Closed
Merged
This was referenced Mar 4, 2020
Open
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
Open
This was referenced Apr 15, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmorehouse tmorehouse tmorehouse approved these changes

Assignees

No one assigned

Labels

PR: Minor Requires minor version bump Type: Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tinymce-vue dialog unable to edit in bootstrap-vue modal.

3 participants

@jacobmllr95 @tmorehouse