🌐 AI搜索 & 代理 主页
Skip to content

feat(b-form-datepicker): add button-content optionally scoped slot for icon #4795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmorehouse merged 16 commits into from
Feb 23, 2020
Merged

feat(b-form-datepicker): add button-content optionally scoped slot for icon #4795

tmorehouse merged 16 commits into from
Feb 23, 2020

Conversation

@andrewvasilchuk
Copy link
Contributor

@andrewvasilchuk andrewvasilchuk commented Feb 19, 2020 •
edited by tmorehouse
Loading

Describe the PR

Add support for button-content slot, which will allow consumers to specify their own button icon/content.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Enhancement
  • ARIA accessibility
  • Documentation update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc). This is very important, as the CHANGELOG is generated from these messages.

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates (including updating the component's package.json for slot and event changes)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (if required)
  • Existing test suites are passing
  • CodeCov for patch has met target
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

jacobmllr95
jacobmllr95 reviewed Feb 19, 2020
View reviewed changes
@jacobmllr95 jacobmllr95 added the Status: Changes Needed Pull request needs changes label Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020 •
edited
Loading

Codecov Report

Merging #4795 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #4795   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files         263      263           
  Lines        5857     5857           
  Branches     1528     1528           
=======================================
  Hits         5853     5853           
  Misses          3        3           
  Partials        1        1
Impacted Files Coverage Δ
src/components/tabs/tab.js 100% <ø> (ø) ⬆️
src/components/tabs/tabs.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6be3d3...77ef71b. Read the comment docs.

@tmorehouse tmorehouse added the PR: Minor Requires minor version bump label Feb 19, 2020
@tmorehouse tmorehouse added Status: Review Needed and removed Status: Changes Needed Pull request needs changes labels Feb 19, 2020
@tmorehouse tmorehouse changed the title feat(b-form-datepicker): add button-content scoped slot feat(b-form-datepicker): add button-content optionally scoped slot Feb 19, 2020
@tmorehouse
Copy link
Member

tmorehouse commented Feb 19, 2020 •
edited
Loading

We will wait to merge this, in case we need to release a patch version to v2.5.0 before v2.6.0

@andrewvasilchuk
Copy link
Contributor Author

andrewvasilchuk commented Feb 20, 2020

Wow, guys, you are so fast. Do I need to do something else? Thanks you a lot 🙏.

@jacobmllr95
Copy link
Member

jacobmllr95 commented Feb 20, 2020

@andrewvasilchuk I think we are fine here now. Thanks :)

tmorehouse
tmorehouse reviewed Feb 20, 2020
View reviewed changes
src/components/form-datepicker/form-datepicker.js
this.hasNormalizedSlot('button-content')
? this.normalizeSlot('button-content', btnScope)
: defaultButtonFn(btnScope)
this.normalizeSlot('button-content', btnScope) || defaultButtonFn(btnScope)
Copy link
Member

@tmorehouse tmorehouse Feb 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only issue with using || instead of a ternary, is that if the slot returns '' it will render the default icon.

Copy link
Member

@jacobmllr95 jacobmllr95 Feb 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmorehouse Hmm, haven't thought about that.

Copy link
Member

@tmorehouse tmorehouse Feb 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always leave as-is for now, and people have issues we can use the hasNormalizedSlot check.

This was referenced Feb 23, 2020
Merged
Merged
@tmorehouse tmorehouse changed the title feat(b-form-datepicker): add button-content optionally scoped slot feat(b-form-datepicker): add button-content optionally scoped slot for icon Feb 23, 2020
@tmorehouse tmorehouse merged commit 7a00910 into bootstrap-vue:dev Feb 23, 2020
@tmorehouse tmorehouse mentioned this pull request Feb 27, 2020
Closed
This was referenced Mar 27, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2020
Open
This was referenced Apr 15, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 30, 2020
Open
@leachimsumiri
Copy link

leachimsumiri commented Sep 11, 2020

what's the syntax for the button-content slot?

@leachimsumiri
Copy link

leachimsumiri commented Sep 11, 2020

got it, it's

<template v-slot:button-content>
</template>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

@tmorehouse tmorehouse tmorehouse approved these changes

Assignees

No one assigned

Labels

PR: Minor Requires minor version bump Type: Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewvasilchuk @tmorehouse @jacobmllr95 @leachimsumiri