fix(v-b-toggle): handle component updates on click listeners (closes #5475) #5690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When the element with the
v-b-toggledirective assigned had other click handlers assigned that triggered a re-render of the element, the toggle click handler was not fired since we re-assign it to pick up any target changes.This PR adds a
requestAnimationFrame()call before re-assigning the click listeners in order to allow any previous click handling to occur first.Closes #5475.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...), requires a patch version updatefeat(...), requires a minor version updatefeat(...), requires a minor version updatefix(...), requires a patch or minor version updatechore(docs), requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch, not themasterbranch[...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)fix(alert): not alerting during SSR render,docs(badge): update pill examples,chore(docs): fix typo in README, etc). This is very important, as theCHANGELOGis generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: