From 73ab473be4e9f769bef508f3037f1cdc6e019c7d Mon Sep 17 00:00:00 2001
From: Troy Morehouse <troymore@nbnet.nb.ca>
Date: Mon, 18 May 2020 18:20:06 -0300
Subject: [PATCH 1/4] fi(v-b-toggle): don't check for `evt.defaultPrevened`
 (closes #5391)

---
 src/directives/toggle/toggle.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/directives/toggle/toggle.js b/src/directives/toggle/toggle.js
index 8725cdf6ef1..975594a4dd8 100644
--- a/src/directives/toggle/toggle.js
+++ b/src/directives/toggle/toggle.js
@@ -88,7 +88,7 @@ const addClickListener = (el, vnode) => {
     const handler = evt => {
       const targets = el[BV_TOGGLE_TARGETS] || []
       const ignore = evt.type === 'keydown' && !arrayIncludes(keyDownEvents, evt.keyCode)
-      if (!evt.defaultPrevented && !ignore && !isDisabled(el)) {
+      if (!ignore && !isDisabled(el)) {
         targets.forEach(target => {
           vnode.context.$root.$emit(EVENT_TOGGLE, target)
         })

From 5b2045ad33ba3a824fec2b7f6adec87f9632c4ab Mon Sep 17 00:00:00 2001
From: Troy Morehouse <troymore@nbnet.nb.ca>
Date: Mon, 18 May 2020 18:23:43 -0300
Subject: [PATCH 2/4] Update README.md

---
 src/directives/toggle/README.md | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/src/directives/toggle/README.md b/src/directives/toggle/README.md
index b5deebfefe2..47daab018f7 100644
--- a/src/directives/toggle/README.md
+++ b/src/directives/toggle/README.md
@@ -93,15 +93,8 @@ trigger element when the target component is closed, and removed when open. As o
 ## Preventing the target from opening or closing
 
 To prevent the trigger element from toggling the target, set the `disabled` prop on `<button>`,
-`<b-button>`, or `<b-link>` and the toggle event will _not_ dispatched to the target(s).
-
-`v-b-toggle` also checks if the `click` event (and `keydown` event for non-button/links) was
-canceled (i.e. via `event.preventDefault()` or `@click.prevent`), and if so, it will _not_ dispatch
-the toggle event to the target(s).
-
-Because of this, avoid placing `v-b-toggle` on a `<b-button>` or `<b-link>` that has the `href` prop
-set to `'#'`, as these components (or components based on them) call `event.preventDefault()` to
-stop the browser from scrolling to the top of the page.
+`<b-button>`, or `<b-link>` (or components based on from `<b-link>`) and the toggle event will
+_not_ dispatched to the target(s).
 
 ## Accessibility
 

From d1016b458f087d97a4d8277e39abf2f873ccc93e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacob=20M=C3=BCller?= <jacob.mueller.elz@gmail.com>
Date: Mon, 18 May 2020 23:45:09 +0200
Subject: [PATCH 3/4] Update README.md

---
 src/directives/toggle/README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/directives/toggle/README.md b/src/directives/toggle/README.md
index 47daab018f7..a639933fec2 100644
--- a/src/directives/toggle/README.md
+++ b/src/directives/toggle/README.md
@@ -93,8 +93,8 @@ trigger element when the target component is closed, and removed when open. As o
 ## Preventing the target from opening or closing
 
 To prevent the trigger element from toggling the target, set the `disabled` prop on `<button>`,
-`<b-button>`, or `<b-link>` (or components based on from `<b-link>`) and the toggle event will
-_not_ dispatched to the target(s).
+`<b-button>`, or `<b-link>` (or components based on from `<b-link>`) and the toggle event will _not_
+dispatched to the target(s).
 
 ## Accessibility
 

From c87ac277e1d6692644bb950e4b2c4caa6a69f0ff Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacob=20M=C3=BCller?= <jacob.mueller.elz@gmail.com>
Date: Mon, 18 May 2020 23:45:21 +0200
Subject: [PATCH 4/4] Update toggle.js

---
 src/directives/toggle/toggle.js | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/directives/toggle/toggle.js b/src/directives/toggle/toggle.js
index 975594a4dd8..6e34a667808 100644
--- a/src/directives/toggle/toggle.js
+++ b/src/directives/toggle/toggle.js
@@ -49,7 +49,7 @@ export const EVENT_STATE_SYNC = 'bv::collapse::sync::state'
 // Private event we send to collapse to request state update sync event
 export const EVENT_STATE_REQUEST = 'bv::request::collapse::state'
 
-const keyDownEvents = [ENTER, SPACE]
+const KEYDOWN_KEY_CODES = [ENTER, SPACE]
 
 const RX_SPLIT_SEPARATOR = /\s+/
 
@@ -86,9 +86,11 @@ const addClickListener = (el, vnode) => {
   removeClickListener(el)
   if (vnode.context) {
     const handler = evt => {
-      const targets = el[BV_TOGGLE_TARGETS] || []
-      const ignore = evt.type === 'keydown' && !arrayIncludes(keyDownEvents, evt.keyCode)
-      if (!ignore && !isDisabled(el)) {
+      if (
+        !(evt.type === 'keydown' && !arrayIncludes(KEYDOWN_KEY_CODES, evt.keyCode)) &&
+        !isDisabled(el)
+      ) {
+        const targets = el[BV_TOGGLE_TARGETS] || []
         targets.forEach(target => {
           vnode.context.$root.$emit(EVENT_TOGGLE, target)
         })