fix(client): normalize method (#2265)

stainless-app[bot] · meorphis · commit 9cc711469875 · 2025-01-13T10:21:13.000-05:00
diff --git a/src/core.ts b/src/core.ts
@@ -522,9 +522,19 @@ export abstract class APIClient {
 
     const timeout = setTimeout(() => controller.abort(), ms);
 
+    const fetchOptions = {
+      signal: controller.signal as any,
+      ...options,
+    };
+    if (fetchOptions.method) {
+      // Custom methods like 'patch' need to be uppercased
+      // See https://github.com/nodejs/undici/issues/2294
+      fetchOptions.method = fetchOptions.method.toUpperCase();
+    }
+
     return (
       // use undefined this binding; fetch errors if bound to something else in browser/cloudflare
-      this.fetch.call(undefined, url, { signal: controller.signal as any, ...options }).finally(() => {
+      this.fetch.call(undefined, url, fetchOptions).finally(() => {
         clearTimeout(timeout);
       })
     );
diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -128,6 +128,24 @@ describe('instantiate client', () => {
     expect(spy).toHaveBeenCalledTimes(1);
   });
 
+  test('normalized method', async () => {
+    let capturedRequest: RequestInit | undefined;
+    const testFetch = async (url: RequestInfo, init: RequestInit = {}): Promise<Response> => {
+      capturedRequest = init;
+      return new Response(JSON.stringify({}), { headers: { 'Content-Type': 'application/json' } });
+    };
+
+    const client = new Cloudflare({
+      baseURL: 'http://localhost:5000/',
+      apiKey: '144c9defac04969c7bfad8efaa8ea194',
+      apiEmail: 'user@example.com',
+      fetch: testFetch,
+    });
+
+    await client.patch('/foo');
+    expect(capturedRequest?.method).toEqual('PATCH');
+  });
+
   describe('baseUrl', () => {
     test('trailing slash', () => {
       const client = new Cloudflare({
