add webhook config tests

ShMcK · ShMcK · commit dec22968c477 · 2021-09-04T10:13:33.000-07:00
Signed-off-by: shmck &lt;shawn.j.mckay@gmail.com&gt;
diff --git a/src/schema/skeleton.ts b/src/schema/skeleton.ts
@@ -183,9 +183,10 @@ export default {
                   },
                 },
               },
+              additionalProperties: false,
             },
-            additionalProperties: false,
           },
+          required: ["url", "events"],
         },
       },
       additionalProperties: false,
diff --git a/src/schema/tutorial.ts b/src/schema/tutorial.ts
@@ -202,9 +202,10 @@ export default {
                   },
                 },
               },
+              additionalProperties: false,
             },
-            additionalProperties: false,
           },
+          required: ["url", "events"],
         },
       },
       additionalProperties: false,
diff --git a/tests/skeleton.test.ts b/tests/skeleton.test.ts
@@ -197,6 +197,38 @@ describe('validate skeleton', () => {
     const valid = validateSkeleton(json)
     expect(valid).toBe(false)
   })
+  it('should fail if webhook url is missing', () => {
+    const json = {
+      ...validJson,
+      config: {
+        ...validJson.config,
+        webhook: {
+          events: {}
+        }
+      }
+    }
+
+    const valid = validateSkeleton(json)
+    expect(valid).toBe(false)
+  })
+  it('should fail if webhook events include non-listed events', () => {
+    const json = {
+      ...validJson,
+      config: {
+        ...validJson.config,
+        webhook: {
+          ...validJson.config.webhook,
+          events: {
+            ...validJson.config.webhook.events,
+            not_an_event: true,
+          }
+        }
+      }
+    }
+
+    const valid = validateSkeleton(json)
+    expect(valid).toBe(false)
+  })
   it('should fail if level is missing id', () => {
     const level1 = { ...validJson.levels[0], id: undefined }
     const json = {
