fix(dropdown): potential infinite loop setting listeners, cleanups

xidedix · xidedix · commit 6097eaf2ec90 · 2025-12-12T17:48:07.000+01:00
diff --git a/projects/coreui-angular/src/lib/accordion/accordion-item/accordion-item.component.html b/projects/coreui-angular/src/lib/accordion/accordion-item/accordion-item.component.html
@@ -10,9 +10,7 @@
 
 <ng-template #defaultAccordionHeaderTemplate>
   <button cAccordionButton [collapsed]="!itemVisible()" [attr.aria-controls]="contentId" (click)="toggleItem()">
-    <ng-container
-      *ngTemplateOutlet="tmpl['accordionHeader'] || defaultAccordionHeaderContentTemplate; context: itemContext">
-    </ng-container>
+    <ng-container *ngTemplateOutlet="tmpl['accordionHeader'] || defaultAccordionHeaderContentTemplate; context: itemContext" />
   </button>
 </ng-template>
 
@@ -22,9 +20,7 @@
 
 <ng-template #defaultAccordionBodyTemplate>
   <div class="accordion-body">
-    <ng-container
-      *ngTemplateOutlet="tmpl['accordionBody'] || defaultAccordionBodyContentTemplate; context: itemContext">
-    </ng-container>
+    <ng-container *ngTemplateOutlet="tmpl['accordionBody'] || defaultAccordionBodyContentTemplate; context: itemContext" />
   </div>
 </ng-template>
 
diff --git a/projects/coreui-angular/src/lib/dropdown/dropdown/dropdown.component.ts b/projects/coreui-angular/src/lib/dropdown/dropdown/dropdown.component.ts
@@ -240,10 +240,12 @@ export class DropdownComponent implements OnDestroy, OnInit {
 
   readonly #visibleEffect = effect(() => {
     const visible = this.visible();
-    this.activeTrap = visible;
-    visible ? this.createPopperInstance() : this.destroyPopperInstance();
-    this.setVisibleState(visible);
-    this.visibleChange?.emit(visible);
+    untracked(() => {
+      this.activeTrap = visible;
+      visible ? this.createPopperInstance() : this.destroyPopperInstance();
+      this.setVisibleState(visible);
+      this.visibleChange?.emit(visible);
+    });
   });
 
   readonly visibleChange = output<boolean>();
diff --git a/projects/coreui-angular/src/lib/popover/popover/popover.component.ts b/projects/coreui-angular/src/lib/popover/popover/popover.component.ts
@@ -12,7 +12,6 @@ import {
   ViewContainerRef
 } from '@angular/core';
 
-
 @Component({
   selector: 'c-popover',
   templateUrl: './popover.component.html',
diff --git a/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav.component.ts b/projects/coreui-angular/src/lib/sidebar/sidebar-nav/sidebar-nav.component.ts
@@ -47,7 +47,7 @@ import { IconDirective } from '@coreui/icons-angular';
     SidebarNavIconPipe,
     SidebarNavBadgePipe,
     forwardRef(() => SidebarNavComponent)
-],
+  ],
   animations: [
     trigger('openClose', [
       state(
