🌐 AI搜索 & 代理 主页
Skip to content

Refs ##### -- Simplified get/set GEOSCoordSeq points. #20383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
smithdc1 wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Refs ##### -- Simplified get/set GEOSCoordSeq points. #20383

smithdc1 wants to merge 3 commits into from
+257 −56

Conversation

@smithdc1
Copy link
Member

@smithdc1 smithdc1 commented Dec 8, 2025

Speculative patch to address #20338 (comment)

@smithdc1
Refs #36036 -- Added m dimension to GEOSCoordSeq.
6409568
@smithdc1
Refs #36036 -- Added note about z argument in GEOSCoordSeq.__init__().
6569acf 
When dropping support for GEOS 3.13 the `GEOSCoordSeq_hasZ()` function will be available on all supported GEOS versions. Instead of the parent geometry providing the z dimension we can reply on GEOSCoordSeq functions directly. This will follow a similar implementation to what was done for the M dimension.

While it could be adopted earlier we would need to guess that geometries with 3 dimensions on GEOS < 3.14 are Z geometries.
@smithdc1
Refs ##### -- Simplified get/set GEOSCoordSeq points.
97240bc
@github-actions github-actions bot added the no ticket Based on PR title, no linked Trac ticket label Dec 8, 2025
@smithdc1 smithdc1 mentioned this pull request Dec 8, 2025
Open
6 tasks
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

📊 Coverage Report for Changed Files

-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
django/contrib/gis/geos/coordseq.py (0.0%): Missing lines 12,63-68,85,88-89,91-92,94-95,99-100,102-103,105-106,110-116,119,122,124-125,127-128,132,136,138-141,143-146,185,187,189,191,212-213,217-218,220,233,235,237-238
django/contrib/gis/geos/point.py (0.0%): Missing lines 73,75
django/contrib/gis/geos/prototypes/coordseq.py (0.0%): Missing lines 2,4,9,25,29-31,48,51,59,61,81-84,99-101,104-106,113
-------------
Total:   80 lines
Missing: 80 lines
Coverage: 0%
-------------

Note: Missing lines are warnings only. Some lines may not be covered by SQLite tests as they are database-specific.

For more information about code coverage on pull requests, see the contributing documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no ticket Based on PR title, no linked Trac ticket

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@smithdc1