Java: Fix input/output naming.

aschackmull · aschackmull · commit 4066c0d84a34 · 2025-12-11T16:24:29.000+01:00
diff --git a/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll b/java/ql/lib/semmle/code/java/dataflow/internal/FlowSummaryImpl.qll
@@ -281,21 +281,21 @@ module SourceSinkInterpretationInput implements
   }
 
   predicate barrierGuardElement(
-    Element e, string output, Public::AcceptingValue acceptingvalue, string kind,
+    Element e, string input, Public::AcceptingValue acceptingvalue, string kind,
     Public::Provenance provenance, string model
   ) {
     exists(
       string namespace, string type, boolean subtypes, string name, string signature, string ext,
-      SourceOrSinkElement baseBarrier, string originalOutput, QlBuiltins::ExtensionId madId
+      SourceOrSinkElement baseBarrier, string originalInput, QlBuiltins::ExtensionId madId
     |
-      barrierGuardModel(namespace, type, subtypes, name, signature, ext, originalOutput,
+      barrierGuardModel(namespace, type, subtypes, name, signature, ext, originalInput,
         acceptingvalue, kind, provenance, madId) and
       model = "MaD:" + madId.toString() and
       baseBarrier = interpretElement(namespace, type, subtypes, name, signature, ext, _) and
       (
-        e = baseBarrier and output = originalOutput
+        e = baseBarrier and input = originalInput
         or
-        correspondingKotlinParameterDefaultsArgSpec(baseBarrier, e, originalOutput, output)
+        correspondingKotlinParameterDefaultsArgSpec(baseBarrier, e, originalInput, input)
       )
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -281,21 +281,21 @@ module SourceSinkInterpretationInput implements`
`281`	`281`	`}`
`282`	`282`
`283`	`283`	`predicate barrierGuardElement(`
`284`		`- Element e, string output, Public::AcceptingValue acceptingvalue, string kind,`
	`284`	`+ Element e, string input, Public::AcceptingValue acceptingvalue, string kind,`
`285`	`285`	`Public::Provenance provenance, string model`
`286`	`286`	`) {`
`287`	`287`	`exists(`
`288`	`288`	`string namespace, string type, boolean subtypes, string name, string signature, string ext,`
`289`		`- SourceOrSinkElement baseBarrier, string originalOutput, QlBuiltins::ExtensionId madId`
	`289`	`+ SourceOrSinkElement baseBarrier, string originalInput, QlBuiltins::ExtensionId madId`
`290`	`290`	`\|`
`291`		`- barrierGuardModel(namespace, type, subtypes, name, signature, ext, originalOutput,`
	`291`	`+ barrierGuardModel(namespace, type, subtypes, name, signature, ext, originalInput,`
`292`	`292`	`acceptingvalue, kind, provenance, madId) and`
`293`	`293`	`model = "MaD:" + madId.toString() and`
`294`	`294`	`baseBarrier = interpretElement(namespace, type, subtypes, name, signature, ext, _) and`
`295`	`295`	`(`
`296`		`- e = baseBarrier and output = originalOutput`
	`296`	`+ e = baseBarrier and input = originalInput`
`297`	`297`	`or`
`298`		`- correspondingKotlinParameterDefaultsArgSpec(baseBarrier, e, originalOutput, output)`
	`298`	`+ correspondingKotlinParameterDefaultsArgSpec(baseBarrier, e, originalInput, input)`
`299`	`299`	`)`
`300`	`300`	`)`
`301`	`301`	`}`