CSS:Tests: Fix tests & support tests under CSS Zoom

mgol · web-flow · commit 071f6dba6bd1 · 2024-06-03T18:15:23.000+02:00
Firefox 126+ implements CSS zoom in a way it affects width computed style very slightly (`100.008px` instead of `100px`); accept that difference. Add a test for support tests resolving the same under CSS zoom & without one. That test uncovered Chrome failing the `reliableTrDimensions` support test under zoom; the test has been fixed. Fixes gh-5489 Closes gh-5495 Ref gh-5496
diff --git a/src/css/support.js b/src/css/support.js
@@ -54,9 +54,9 @@ support.reliableTrDimensions = function() {
 		}
 
 		trStyle = window.getComputedStyle( tr );
-		reliableTrDimensionsVal = ( parseInt( trStyle.height, 10 ) +
-				parseInt( trStyle.borderTopWidth, 10 ) +
-				parseInt( trStyle.borderBottomWidth, 10 ) ) === tr.offsetHeight;
+		reliableTrDimensionsVal = ( Math.round( parseFloat( trStyle.height ) ) +
+			Math.round( parseFloat( trStyle.borderTopWidth ) ) +
+			Math.round( parseFloat( trStyle.borderBottomWidth ) ) ) === tr.offsetHeight;
 
 		documentElement.removeChild( table );
 	}
diff --git a/test/data/support/zoom.html b/test/data/support/zoom.html
@@ -0,0 +1,24 @@
+<!DOCTYPE html>
+<html>
+<head>
+	<meta charset="utf-8" />
+	<style>
+		html {
+			zoom: 2.1;
+		}
+	</style>
+</head>
+<body>
+	<div>
+		<script src="../../jquery.js"></script>
+		<script src="../iframeTest.js"></script>
+		<script src="getComputedSupport.js"></script>
+	</div>
+	<script>
+		startIframeTest(
+			getComputedStyle( document.documentElement ),
+			getComputedSupport( jQuery.support )
+		);
+	</script>
+</body>
+</html>
diff --git a/test/unit/css.js b/test/unit/css.js
@@ -1381,8 +1381,12 @@ testIframe(
 	"css/cssWidthBrowserZoom.html",
 	function( assert, jQuery, window, document, widthBeforeSet, widthAfterSet ) {
 		assert.expect( 2 );
-		assert.strictEqual( widthBeforeSet, "100px", "elem.css('width') works correctly with browser zoom" );
-		assert.strictEqual( widthAfterSet, "100px", "elem.css('width', val) works correctly with browser zoom" );
+
+		// Support: Firefox 126+
+		// Newer Firefox implements CSS zoom in a way it affects
+		// those values slightly.
+		assert.ok( /^100(?:|\.0\d*)px$/.test( widthBeforeSet ), "elem.css('width') works correctly with browser zoom" );
+		assert.ok( /^100(?:|\.0\d*)px$/.test( widthAfterSet ), "elem.css('width', val) works correctly with browser zoom" );
 	}
 );
 
diff --git a/test/unit/support.js b/test/unit/support.js
@@ -66,6 +66,16 @@ testIframe(
 	}
 );
 
+testIframe(
+	"Verify correctness of support tests with CSS zoom on the root element",
+	"support/zoom.html",
+	function( assert, jQuery, window, document, htmlStyle, support ) {
+		assert.expect( 1 );
+		assert.deepEqual( jQuery.extend( {}, support ), computedSupport,
+			"Same support properties" );
+	}
+);
+
 ( function() {
 	var expected, browserKey,
 		userAgent = window.navigator.userAgent,

Original file line number	Diff line number	Diff line change
`@@ -54,9 +54,9 @@ support.reliableTrDimensions = function() {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`trStyle = window.getComputedStyle( tr );`
`57`		`- reliableTrDimensionsVal = ( parseInt( trStyle.height, 10 ) +`
`58`		`- parseInt( trStyle.borderTopWidth, 10 ) +`
`59`		`- parseInt( trStyle.borderBottomWidth, 10 ) ) === tr.offsetHeight;`
	`57`	`+ reliableTrDimensionsVal = ( Math.round( parseFloat( trStyle.height ) ) +`
	`58`	`+ Math.round( parseFloat( trStyle.borderTopWidth ) ) +`
	`59`	`+ Math.round( parseFloat( trStyle.borderBottomWidth ) ) ) === tr.offsetHeight;`
`60`	`60`
`61`	`61`	`documentElement.removeChild( table );`
`62`	`62`	`}`