Effect: Fix a unnecessary conditional statement in .stop()

wonseop · mgol · commit 110802c7f22b · 2019-05-01T14:57:55.000+02:00
Because of the above conditional, the 'type' variable has a value of type 'string' or undefined. Therefore, boolean comparisons for 'type' variable is always unnecessary because it return true. The patch removed the unnecessary conditional statement. Fixes gh-4374 Closes gh-4375
diff --git a/src/effects.js b/src/effects.js
@@ -538,7 +538,7 @@ jQuery.fn.extend( {
 			clearQueue = type;
 			type = undefined;
 		}
-		if ( clearQueue && type !== false ) {
+		if ( clearQueue ) {
 			this.queue( type || "fx", [] );
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -538,7 +538,7 @@ jQuery.fn.extend( {`
`538`	`538`	`clearQueue = type;`
`539`	`539`	`type = undefined;`
`540`	`540`	`}`
`541`		`- if ( clearQueue && type !== false ) {`
	`541`	`+ if ( clearQueue ) {`
`542`	`542`	`this.queue( type \|\| "fx", [] );`
`543`	`543`	`}`
`544`	`544`