Manipulation: Restore _evalUrl jQuery.ajax calls to dataType: script

gibson042 · web-flow · commit 13de7c9ede1c · 2018-12-13T12:54:39.000-05:00
IE and iOS <10 XHR transport does not succeed on data: URIs Ref gh-4243 Ref gh-4126 Closes gh-4258
diff --git a/src/manipulation/_evalUrl.js b/src/manipulation/_evalUrl.js
@@ -10,15 +10,19 @@ jQuery._evalUrl = function( url ) {
 
 		// Make this explicit, since user can override this through ajaxSetup (#11264)
 		type: "GET",
-		dataType: "text",
+		dataType: "script",
 		cache: true,
 		async: false,
 		global: false,
-		"throws": true,
 
 		// Only evaluate the response if it is successful (gh-4126)
-		success: function( text ) {
-			jQuery.globalEval( text );
+		// dataFilter is not invoked for failure responses, so using it instead
+		// of the default converter is kludgy but it works.
+		converters: {
+			"text script": function() {}
+		},
+		dataFilter: function( response ) {
+			jQuery.globalEval( response );
 		}
 	} );
 };
