🌐 AI搜索 & 代理 主页
Skip to content

Commit 95e34b6

Browse files
mgolmgol
authored
Docs: Replace #NUMBER Trac issue references with trac-NUMBER
This is a version of gh-4993 for the `3.x-stable` branch. The GitHub UI treats `#NUMBER` as referring to its own issues which is confusing when in jQuery source it's usually referring to the old deprecated Trac instance at https://bugs.jquery.com. This change replaces all such Trac references with `trac-NUMBER`. A few of the references came with the Sizzle integration and referred to the Sizzle GitHub bug tracker. Those have been replaced with full links instead. A new entry describing issue reference conventions has been added to README. Closes gh-4994 Ref gh-4993 Ref 5d5ea01
1 parent fa70e8f commit 95e34b6

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+404
-398
lines changed

‎README.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@ In the spirit of open source software development, jQuery always encourages comm
1414
2. [Core Style Guide](https://contribute.jquery.org/style-guide/js/)
1515
3. [Writing Code for jQuery Foundation Projects](https://contribute.jquery.org/code/)
1616

17+
### References to issues/PRs
18+
19+
GitHub issues/PRs are usually referenced via `gh-NUMBER`, where `NUMBER` is the numerical ID of the issue/PR. You can find such an issue/PR under `https://github.com/jquery/jquery/issues/NUMBER`.
20+
21+
jQuery has used a different bug tracker - based on Trac - in the past, available under [bugs.jquery.com](https://bugs.jquery.com/). It is being kept in read only mode so that referring to past discussions is possible. When jQuery source references one of those issues, it uses the pattern `trac-NUMBER`, where `NUMBER` is the numerical ID of the issue. You can find such an issue under `https://bugs.jquery.com/ticket/NUMBER`.
22+
1723

1824
Environments in which to use jQuery
1925
--------------------------------------

‎src/ajax.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ var
2222
rantiCache = /([?&])_=[^&]*/,
2323
rheaders = /^(.*?):[ \t]*([^\r\n]*)$/mg,
2424

25-
// #7653, #8125, #8152: local protocol detection
25+
// trac-7653, trac-8125, trac-8152: local protocol detection
2626
rlocalProtocol = /^(?:about|app|app-storage|.+-extension|file|res|widget):$/,
2727
rnoContent = /^(?:GET|HEAD)$/,
2828
rprotocol = /^\/\//,
@@ -45,7 +45,7 @@ var
4545
*/
4646
transports = {},
4747

48-
// Avoid comment-prolog char sequence (#10098); must appease lint and evade compression
48+
// Avoid comment-prolog char sequence (trac-10098); must appease lint and evade compression
4949
allTypes = "*/".concat( "*" ),
5050

5151
// Anchor tag for parsing the document origin
@@ -116,7 +116,7 @@ function inspectPrefiltersOrTransports( structure, options, originalOptions, jqX
116116

117117
// A special extend for ajax options
118118
// that takes "flat" options (not to be deep extended)
119-
// Fixes #9887
119+
// Fixes trac-9887
120120
function ajaxExtend( target, src ) {
121121
var key, deep,
122122
flatOptions = jQuery.ajaxSettings.flatOptions || {};
@@ -527,12 +527,12 @@ jQuery.extend( {
527527
deferred.promise( jqXHR );
528528

529529
// Add protocol if not provided (prefilters might expect it)
530-
// Handle falsy url in the settings object (#10093: consistency with old signature)
530+
// Handle falsy url in the settings object (trac-10093: consistency with old signature)
531531
// We also use the url parameter if available
532532
s.url = ( ( url || s.url || location.href ) + "" )
533533
.replace( rprotocol, location.protocol + "//" );
534534

535-
// Alias method option to type as per ticket #12004
535+
// Alias method option to type as per ticket trac-12004
536536
s.type = options.method || options.type || s.method || s.type;
537537

538538
// Extract dataTypes list
@@ -575,7 +575,7 @@ jQuery.extend( {
575575
}
576576

577577
// We can fire global events as of now if asked to
578-
// Don't fire events if jQuery.event is undefined in an AMD-usage scenario (#15118)
578+
// Don't fire events if jQuery.event is undefined in an AMD-usage scenario (trac-15118)
579579
fireGlobals = jQuery.event && s.global;
580580

581581
// Watch for a new set of requests
@@ -604,7 +604,7 @@ jQuery.extend( {
604604
if ( s.data && ( s.processData || typeof s.data === "string" ) ) {
605605
cacheURL += ( rquery.test( cacheURL ) ? "&" : "?" ) + s.data;
606606

607-
// #9682: remove data so that it's not used in an eventual retry
607+
// trac-9682: remove data so that it's not used in an eventual retry
608608
delete s.data;
609609
}
610610

‎src/ajax/xhr.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var xhrSuccessStatus = {
1818
0: 200,
1919

2020
// Support: IE <=9 only
21-
// #1450: sometimes IE returns 1223 when it should be 204
21+
// trac-1450: sometimes IE returns 1223 when it should be 204
2222
1223: 204
2323
},
2424
xhrSupported = jQuery.ajaxSettings.xhr();
@@ -90,7 +90,7 @@ jQuery.ajaxTransport( function( options ) {
9090
} else {
9191
complete(
9292

93-
// File: protocol always yields status 0; see #8605, #14207
93+
// File: protocol always yields status 0; see trac-8605, trac-14207
9494
xhr.status,
9595
xhr.statusText
9696
);
@@ -151,7 +151,7 @@ jQuery.ajaxTransport( function( options ) {
151151
xhr.send( options.hasContent && options.data || null );
152152
} catch ( e ) {
153153

154-
// #14683: Only rethrow if this hasn't been notified as an error yet
154+
// trac-14683: Only rethrow if this hasn't been notified as an error yet
155155
if ( callback ) {
156156
throw e;
157157
}

‎src/attributes/prop.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jQuery.extend( {
6262
// Support: IE <=9 - 11 only
6363
// elem.tabIndex doesn't always return the
6464
// correct value when it hasn't been explicitly set
65-
// Use proper attribute retrieval(#12072)
65+
// Use proper attribute retrieval (trac-12072)
6666
var tabindex = jQuery.find.attr( elem, "tabindex" );
6767

6868
if ( tabindex ) {

‎src/attributes/val.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ jQuery.extend( {
9191
val :
9292

9393
// Support: IE <=10 - 11 only
94-
// option.text throws exceptions (#14686, #14858)
94+
// option.text throws exceptions (trac-14686, trac-14858)
9595
// Strip and collapse whitespace
9696
// https://html.spec.whatwg.org/#strip-and-collapse-whitespace
9797
stripAndCollapse( jQuery.text( elem ) );
@@ -118,7 +118,7 @@ jQuery.extend( {
118118
option = options[ i ];
119119

120120
// Support: IE <=9 only
121-
// IE8-9 doesn't update selected after form reset (#2551)
121+
// IE8-9 doesn't update selected after form reset (trac-2551)
122122
if ( ( option.selected || i === index ) &&
123123

124124
// Don't return options that are disabled or in a disabled optgroup

‎src/core/camelCase.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function fcamelCase( _all, letter ) {
1313

1414
// Convert dashed to camelCase; used by the css and data modules
1515
// Support: IE <=9 - 11, Edge 12 - 15
16-
// Microsoft forgot to hump their vendor prefix (#9572)
16+
// Microsoft forgot to hump their vendor prefix (trac-9572)
1717
function camelCase( string ) {
1818
return string.replace( rmsPrefix, "ms-" ).replace( rdashAlpha, fcamelCase );
1919
}

‎src/core/init.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ define( [
1414
var rootjQuery,
1515

1616
// A simple way to check for HTML strings
17-
// Prioritize #id over <tag> to avoid XSS via location.hash (#9521)
18-
// Strict HTML recognition (#11290: must start with <)
17+
// Prioritize #id over <tag> to avoid XSS via location.hash (trac-9521)
18+
// Strict HTML recognition (trac-11290: must start with <)
1919
// Shortcut simple #id case for speed
2020
rquickExpr = /^(?:\s*(<[\w\W]+>)[^>]*|#([\w-]+))$/,
2121

‎src/core/ready-no-deferred.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jQuery.extend( {
3030
isReady: false,
3131

3232
// A counter to track how many items to wait for before
33-
// the ready event fires. See #6781
33+
// the ready event fires. See trac-6781
3434
readyWait: 1,
3535

3636
ready: function( wait ) {

‎src/core/ready.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jQuery.extend( {
3131
isReady: false,
3232

3333
// A counter to track how many items to wait for before
34-
// the ready event fires. See #6781
34+
// the ready event fires. See trac-6781
3535
readyWait: 1,
3636

3737
// Handle when the DOM is ready

‎src/css.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -265,15 +265,15 @@ jQuery.extend( {
265265
if ( value !== undefined ) {
266266
type = typeof value;
267267

268-
// Convert "+=" or "-=" to relative numbers (#7345)
268+
// Convert "+=" or "-=" to relative numbers (trac-7345)
269269
if ( type === "string" && ( ret = rcssNum.exec( value ) ) && ret[ 1 ] ) {
270270
value = adjustCSS( elem, name, ret );
271271

272-
// Fixes bug #9237
272+
// Fixes bug trac-9237
273273
type = "number";
274274
}
275275

276-
// Make sure that null and NaN values aren't set (#7116)
276+
// Make sure that null and NaN values aren't set (trac-7116)
277277
if ( value == null || value !== value ) {
278278
return;
279279
}

0 commit comments

Comments
 (0)