Core: Don't rely on splice being present on input

bubbatls · web-flow · commit 9c6f64c7b51d · 2022-01-24T18:55:16.000+01:00
Without this fix calling `jQuery.uniqueSort` on an array-like can result in: TypeError: results.splice is not a function at Function.jQuery.uniqueSort (https://code.jquery.com/jquery-git.js:664:12) at jQuery.fn.init.find (https://code.jquery.com/jquery-git.js:2394:27) at gocusihafe.js:3:4 Closes gh-4986
diff --git a/src/selector/uniqueSort.js b/src/selector/uniqueSort.js
@@ -1,6 +1,7 @@
 import jQuery from "../core.js";
 import document from "../var/document.js";
 import sort from "../var/sort.js";
+import splice from "../var/splice.js";
 
 var hasDuplicate;
 
@@ -80,7 +81,7 @@ jQuery.uniqueSort = function( results ) {
 			}
 		}
 		while ( j-- ) {
-			results.splice( duplicates[ j ], 1 );
+			splice.call( results, duplicates[ j ], 1 );
 		}
 	}
 
diff --git a/src/var/splice.js b/src/var/splice.js
@@ -0,0 +1,3 @@
+import arr from "./arr.js";
+
+export default arr.splice;
diff --git a/test/unit/selector.js b/test/unit/selector.js
@@ -1895,9 +1895,7 @@ QUnit.test( "jQuery.uniqueSort", function( assert ) {
 		}
 	}
 	Arrayish.prototype = {
-		slice: [].slice,
-		sort: [].sort,
-		splice: [].splice
+		sliceForTestOnly: [].slice
 	};
 
 	var i, tests,
@@ -1959,8 +1957,12 @@ QUnit.test( "jQuery.uniqueSort", function( assert ) {
 
 	jQuery.each( tests, function( label, test ) {
 		var length = test.length || test.input.length;
-		assert.deepEqual( jQuery.uniqueSort( test.input ).slice( 0, length ), test.expected, label + " (array)" );
-		assert.deepEqual( jQuery.uniqueSort( new Arrayish( test.input ) ).slice( 0, length ), test.expected, label + " (quasi-array)" );
+		// We duplicate `test.input` because otherwise it is modified by `uniqueSort`
+		// and the second test becomes worthless.
+		assert.deepEqual( jQuery.uniqueSort( test.input.slice( 0 ) ).slice( 0, length ),
+			test.expected, label + " (array)" );
+		assert.deepEqual( jQuery.uniqueSort( new Arrayish( test.input ) ).sliceForTestOnly( 0, length ),
+			test.expected, label + " (quasi-array)" );
 	} );
 } );
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`import jQuery from "../core.js";`
`2`	`2`	`import document from "../var/document.js";`
`3`	`3`	`import sort from "../var/sort.js";`
	`4`	`+import splice from "../var/splice.js";`
`4`	`5`
`5`	`6`	`var hasDuplicate;`
`6`	`7`
`@@ -80,7 +81,7 @@ jQuery.uniqueSort = function( results ) {`
`80`	`81`	`}`
`81`	`82`	`}`
`82`	`83`	`while ( j-- ) {`
`83`		`- results.splice( duplicates[ j ], 1 );`
	`84`	`+ splice.call( results, duplicates[ j ], 1 );`
`84`	`85`	`}`
`85`	`86`	`}`
`86`	`87`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import arr from "./arr.js";`
	`2`	`+`
	`3`	`+export default arr.splice;`