🌐 AI搜索 & 代理 主页
Skip to content

Commit a4ad702

Browse files
author
karan-96
committed
Core: Deprecate jQuery.nodeName
Fixes gh-3475
1 parent 78e1c0c commit a4ad702

File tree

7 files changed

+21
-20
lines changed

7 files changed

+21
-20
lines changed

‎src/attributes/attr.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
define( [
22
"../core",
33
"../core/access",
4+
"../core/nodeName",
45
"./support",
56
"../var/rnothtmlwhite",
6-
"../selector",
7-
"../core/nodeName"
8-
], function( jQuery, access, support, rnothtmlwhite, nodeName ) {
7+
"../selector"
8+
], function( jQuery, access, nodeName, support, rnothtmlwhite ) {
99

1010
"use strict";
1111

‎src/event.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ define( [
77
"./var/slice",
88
"./data/var/dataPriv",
99
"./core/init",
10-
"./selector",
11-
"./core/nodeName"
10+
"./core/nodeName",
11+
"./selector"
1212
], function( jQuery, document, documentElement, rnothtmlwhite, rcheckableType, slice, dataPriv,
1313
nodeName ) {
1414

‎src/manipulation.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ define( [
1616
"./data/var/dataUser",
1717
"./data/var/acceptData",
1818
"./core/DOMEval",
19-
"./core/nodeName",
2019

2120
"./core/init",
21+
"./core/nodeName",
2222
"./traversing",
2323
"./selector",
2424
"./event"

‎src/offset.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ define( [
77
"./css/curCSS",
88
"./css/addGetHookIf",
99
"./css/support",
10-
"./core/nodeName",
1110

1211
"./core/init",
12+
"./core/nodeName",
1313
"./css",
1414
"./selector" // contains
1515
], function( jQuery, access, document, documentElement, rnumnonpx, curCSS, addGetHookIf, support,

‎src/traversing.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,10 @@ define( [
55
"./traversing/var/siblings",
66
"./traversing/var/rneedsContext",
77
"./core/init",
8+
"./core/nodeName",
89
"./traversing/findFilter",
910
"./selector"
10-
], function( jQuery, indexOf, dir, siblings, rneedsContext ) {
11+
], function( jQuery, indexOf, dir, siblings, rneedsContext, nodeName ) {
1112

1213
"use strict";
1314

@@ -143,14 +144,14 @@ jQuery.each( {
143144
return siblings( elem.firstChild );
144145
},
145146
contents: function( elem ) {
146-
if ( jQuery.nodeName( elem, "iframe" ) ) {
147+
if ( nodeName( elem, "iframe" ) ) {
147148
return elem.contentDocument;
148149
}
149150

150151
// Support: IE 9 - 11 only, iOS 7 only, Android Browser <=4.3 only
151152
// Treat the template element as a regular one in browsers that
152153
// don't support it.
153-
if ( jQuery.nodeName( elem, "template" ) ) {
154+
if ( nodeName( elem, "template" ) ) {
154155
elem = elem.content || elem;
155156
}
156157

‎test/unit/core.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -696,15 +696,15 @@ QUnit.test( "jQuery(element with non-alphanumeric name)", function( assert ) {
696696
var tagName = tag + symbol + "test";
697697
var el = jQuery( "<" + tagName + "></" + tagName + ">" );
698698
assert.ok( el[ 0 ], "Create a " + tagName + " element" );
699-
assert.ok( jQuery.nodeName( el[ 0 ], tagName.toUpperCase() ),
699+
assert.ok( el[ 0 ].nodeName === tagName.toUpperCase(),
700700
tagName + " element has expected node name" );
701701
}
702702
);
703703

704704
var tagName = [ "tr", "multiple", "symbol" ].join( symbol );
705705
var el = jQuery( "<" + tagName + "></" + tagName + ">" );
706706
assert.ok( el[ 0 ], "Create a " + tagName + " element" );
707-
assert.ok( jQuery.nodeName( el[ 0 ], tagName.toUpperCase() ),
707+
assert.ok( el[ 0 ].nodeName === tagName.toUpperCase(),
708708
tagName + " element has expected node name" );
709709
} );
710710
} );

‎test/unit/manipulation.js‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -474,13 +474,13 @@ QUnit.test( "html(String) tag-hyphenated elements (Bug #1987)", function( assert
474474
jQuery.each( "thead tbody tfoot colgroup caption tr th td".split( " " ), function( i, name ) {
475475
var j = jQuery( "<" + name + "-d></" + name + "-d><" + name + "-d></" + name + "-d>" );
476476
assert.ok( j[ 0 ], "Create a tag-hyphenated element" );
477-
assert.ok( jQuery.nodeName( j[ 0 ], name.toUpperCase() + "-D" ), "Hyphenated node name" );
478-
assert.ok( jQuery.nodeName( j[ 1 ], name.toUpperCase() + "-D" ), "Hyphenated node name" );
477+
assert.ok( j[ 0 ].nodeName === name.toUpperCase() + "-D", "Hyphenated node name" );
478+
assert.ok( j[ 1 ].nodeName === name.toUpperCase() + "-D", "Hyphenated node name" );
479479
} );
480480

481481
var j = jQuery( "<tr-multiple-hyphens><td-with-hyphen>text</td-with-hyphen></tr-multiple-hyphens>" );
482-
assert.ok( jQuery.nodeName( j[ 0 ], "TR-MULTIPLE-HYPHENS" ), "Tags with multiple hyphens" );
483-
assert.ok( jQuery.nodeName( j.children()[ 0 ], "TD-WITH-HYPHEN" ), "Tags with multiple hyphens" );
482+
assert.ok( j[ 0 ].nodeName === "TR-MULTIPLE-HYPHENS", "Tags with multiple hyphens" );
483+
assert.ok( j.children()[ 0 ].nodeName === "TD-WITH-HYPHEN", "Tags with multiple hyphens" );
484484
assert.equal( j.children().text(), "text", "Tags with multiple hyphens behave normally" );
485485
} );
486486

@@ -2616,14 +2616,14 @@ QUnit.test( "Make sure specific elements with content created correctly (#13232)
26162616

26172617
jQuery.each( elems, function( name, value ) {
26182618
var html = "<" + name + ">" + value + "</" + name + ">";
2619-
assert.ok( jQuery.nodeName( jQuery.parseHTML( "<" + name + ">" + value + "</" + name + ">" )[ 0 ], name ), name + " is created correctly" );
2619+
assert.ok( jQuery.parseHTML( "<" + name + ">" + value + "</" + name + ">" )[ 0 ].nodeName.toLowerCase() === name, name + " is created correctly" );
26202620

26212621
results.push( name );
26222622
args.push( html );
26232623
} );
26242624

26252625
jQuery.fn.append.apply( jQuery( "<div/>" ), args ).children().each( function( i ) {
2626-
assert.ok( jQuery.nodeName( this, results[ i ] ) );
2626+
assert.ok( this.nodeName.toLowerCase() === results[ i ] );
26272627
} );
26282628
} );
26292629

@@ -2634,11 +2634,11 @@ QUnit.test( "Validate creation of multiple quantities of certain elements (#1381
26342634

26352635
jQuery.each( tags, function( index, tag ) {
26362636
jQuery( "<" + tag + "/><" + tag + "/>" ).each( function() {
2637-
assert.ok( jQuery.nodeName( this, tag ), tag + " empty elements created correctly" );
2637+
assert.ok( this.nodeName.toLowerCase() === tag, tag + " empty elements created correctly" );
26382638
} );
26392639

26402640
jQuery( "<" + this + "></" + tag + "><" + tag + "></" + tag + ">" ).each( function() {
2641-
assert.ok( jQuery.nodeName( this, tag ), tag + " elements with closing tag created correctly" );
2641+
assert.ok( this.nodeName.toLowerCase() === tag, tag + " elements with closing tag created correctly" );
26422642
} );
26432643
} );
26442644
} );

0 commit comments

Comments
 (0)