Deferred: Deprecate setTimeout() usage under latest browsers.

diegocr · diegocr · commit de48171d43b9 · 2022-09-14T17:20:12.000+02:00
diff --git a/src/deferred.js b/src/deferred.js
@@ -40,6 +40,8 @@ function adoptValue( value, resolve, reject, noValue ) {
 	}
 }
 
+var asap = window.queueMicrotask || window.setTimeout;
+
 jQuery.extend( {
 
 	Deferred: function( func ) {
@@ -221,7 +223,7 @@ jQuery.extend( {
 								if ( jQuery.Deferred.getStackHook ) {
 									process.stackTrace = jQuery.Deferred.getStackHook();
 								}
-								window.setTimeout( process );
+								asap( process );
 							}
 						};
 					}
diff --git a/test/unit/core.js b/test/unit/core.js
@@ -1522,7 +1522,37 @@ testIframe(
 	}
 );
 
-QUnit[ includesModule( "deferred" ) ? "test" : "skip" ]( "jQuery.readyException (original)", function( assert ) {
+QUnit[ includesModule( "deferred" ) && window.queueMicrotask ? "test" : "skip" ]( "jQuery.readyException (microtask)", function( assert ) {
+	assert.expect( 2 );
+
+	var done = assert.async();
+	var expected = "Error in jQuery ready #" + Math.random().toString( 36 ).slice( -7 );
+
+	this.sandbox.stub( jQuery, "readyException" ).callsFake( function( error ) {
+		assert.strictEqual( error.message, expected, "jQuery.readyException called with unexpected error" );
+		window.setTimeout( function() {
+			throw error;
+		} );
+	} );
+
+	this.sandbox.stub( window, "setTimeout" ).callsFake( function( fn ) {
+		var message;
+		try {
+			fn();
+		} catch ( error ) {
+			message = error.message;
+		}
+
+		assert.strictEqual( message, expected, "The error should have been caught" );
+		done();
+	} );
+
+	jQuery( function() {
+		throw new Error( expected );
+	} );
+} );
+
+QUnit[ includesModule( "deferred" ) && !window.queueMicrotask ? "test" : "skip" ]( "jQuery.readyException (timer)", function( assert ) {
 	assert.expect( 1 );
 
 	var message;

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,8 @@ function adoptValue( value, resolve, reject, noValue ) {`
`40`	`40`	`}`
`41`	`41`	`}`
`42`	`42`
	`43`	`+var asap = window.queueMicrotask \|\| window.setTimeout;`
	`44`	`+`
`43`	`45`	`jQuery.extend( {`
`44`	`46`
`45`	`47`	`Deferred: function( func ) {`
`@@ -221,7 +223,7 @@ jQuery.extend( {`
`221`	`223`	`if ( jQuery.Deferred.getStackHook ) {`
`222`	`224`	`process.stackTrace = jQuery.Deferred.getStackHook();`
`223`	`225`	`}`
`224`		`- window.setTimeout( process );`
	`226`	`+ asap( process );`
`225`	`227`	`}`
`226`	`228`	`};`
`227`	`229`	`}`