From 0c12e491c2b8f85de7368c754e605156a2b51bf2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Mon, 28 Oct 2019 20:24:46 +0100 Subject: [PATCH] Tests: Skip a "width/height on a table row with phantom borders" test in Firefox Firefox 70 & newer fail this test but the issue there is more profound - Firefox doesn't subtract borders from table row computed widths. Ref jquery/jquery#4529 Ref https://bugzilla.mozilla.org/show_bug.cgi?id=1590837 Ref w3c/csswg-drafts#4444 --- test/unit/dimensions.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/test/unit/dimensions.js b/test/unit/dimensions.js index 23a58523cf..f4dc0bd1aa 100644 --- a/test/unit/dimensions.js +++ b/test/unit/dimensions.js @@ -627,7 +627,14 @@ QUnit.test( "width/height on an inline element with percentage dimensions (gh-36 } ); -QUnit.test( "width/height on a table row with phantom borders (gh-3698)", function( assert ) { +// Support: Firefox 70+ +// Firefox 70 & newer fail this test but the issue there is more profound - Firefox doesn't +// subtract borders from table row computed widths. +// See https://github.com/jquery/jquery/issues/4529 +// See https://bugzilla.mozilla.org/show_bug.cgi?id=1590837 +// See https://github.com/w3c/csswg-drafts/issues/4444 +QUnit[ /firefox/i.test( navigator.userAgent ) ? "skip" : "test" ]( + "width/height on a table row with phantom borders (gh-3698)", function( assert ) { assert.expect( 4 ); jQuery( "" +