From 2294a8f0cde395ad0912d053ae9a19c013120e23 Mon Sep 17 00:00:00 2001
From: Carlos Serrano <carlos.pastor@mailonline.co.uk>
Date: Mon, 29 Apr 2024 09:03:39 +0200
Subject: [PATCH 01/14] ci: add scorecard pipeline (#158)

PR-URL: https://github.com/jshttp/cookie/pull/158
---
 .github/workflows/scorecard.yml | 72 +++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 .github/workflows/scorecard.yml

diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
new file mode 100644
index 0000000..3bfd85a
--- /dev/null
+++ b/.github/workflows/scorecard.yml
@@ -0,0 +1,72 @@
+# This workflow uses actions that are not certified by GitHub. They are provided
+# by a third-party and are governed by separate terms of service, privacy
+# policy, and support documentation.
+
+name: Scorecard supply-chain security
+on:
+  # For Branch-Protection check. Only the default branch is supported. See
+  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection
+  branch_protection_rule:
+  # To guarantee Maintained check is occasionally updated. See
+  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained
+  schedule:
+    - cron: '16 21 * * 1'
+  push:
+    branches: [ "master" ]
+
+# Declare default permissions as read only.
+permissions: read-all
+
+jobs:
+  analysis:
+    name: Scorecard analysis
+    runs-on: ubuntu-latest
+    permissions:
+      # Needed to upload the results to code-scanning dashboard.
+      security-events: write
+      # Needed to publish results and get a badge (see publish_results below).
+      id-token: write
+      # Uncomment the permissions below if installing in a private repository.
+      # contents: read
+      # actions: read
+
+    steps:
+      - name: "Checkout code"
+        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
+        with:
+          persist-credentials: false
+
+      - name: "Run analysis"
+        uses: ossf/scorecard-action@99c53751e09b9529366343771cc321ec74e9bd3d # v2.0.6
+        with:
+          results_file: results.sarif
+          results_format: sarif
+          # (Optional) "write" PAT token. Uncomment the `repo_token` line below if:
+          # - you want to enable the Branch-Protection check on a *public* repository, or
+          # - you are installing Scorecard on a *private* repository
+          # To create the PAT, follow the steps in https://github.com/ossf/scorecard-action#authentication-with-pat.
+          # repo_token: ${{ secrets.SCORECARD_TOKEN }}
+
+          # Public repositories:
+          #   - Publish results to OpenSSF REST API for easy access by consumers
+          #   - Allows the repository to include the Scorecard badge.
+          #   - See https://github.com/ossf/scorecard-action#publishing-results.
+          # For private repositories:
+          #   - `publish_results` will always be set to `false`, regardless
+          #     of the value entered here.
+          publish_results: true
+
+      # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
+      # format to the repository Actions tab.
+      - name: "Upload artifact"
+        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
+        with:
+          name: SARIF file
+          path: results.sarif
+          retention-days: 5
+
+      # Upload the results to GitHub's code scanning dashboard.
+      - name: "Upload to code-scanning"
+        uses: github/codeql-action/upload-sarif@2f93e4319b2f04a2efc38fa7f78bd681bc3f7b2f # v2.23.2
+        with:
+          sarif_file: results.sarif
\ No newline at end of file

From 26031e362d8473112b24a76c7c03b45ef7576d61 Mon Sep 17 00:00:00 2001
From: Nell Boulle <jonathanboulle@gmail.com>
Date: Mon, 29 Apr 2024 13:10:15 +0200
Subject: [PATCH 02/14] docs: fix typo in function description (#161)

PR-URL: https://github.com/jshttp/cookie/pull/161
---
 index.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/index.js b/index.js
index 03d4c38..7506a79 100644
--- a/index.js
+++ b/index.js
@@ -95,8 +95,8 @@ function parse(str, options) {
 /**
  * Serialize data into a cookie header.
  *
- * Serialize the a name value pair into a cookie string suitable for
- * http headers. An optional options object specified cookie parameters.
+ * Serialize a name value pair into a cookie string suitable for
+ * http headers. An optional options object specifies cookie parameters.
  *
  * serialize('foo', 'bar', { httpOnly: true })
  *   => "foo=bar; httpOnly"

From e10042845354fea83bd8f34af72475eed1dadf5c Mon Sep 17 00:00:00 2001
From: Brian Ewins <119598239+bewinsnw@users.noreply.github.com>
Date: Tue, 1 Oct 2024 23:56:55 +0100
Subject: [PATCH 03/14] fix: narrow the validation of cookies to match RFC6265
 (#167)

---
 index.js          | 64 ++++++++++++++++++++++++++++++++++++++++-------
 test/serialize.js |  4 +++
 2 files changed, 59 insertions(+), 9 deletions(-)

diff --git a/index.js b/index.js
index 7506a79..6fe633d 100644
--- a/index.js
+++ b/index.js
@@ -23,14 +23,60 @@ exports.serialize = serialize;
 var __toString = Object.prototype.toString
 
 /**
- * RegExp to match field-content in RFC 7230 sec 3.2
+ * RegExp to match cookie-name in RFC 6265 sec 4.1.1
+ * This refers out to the obsoleted definition of token in RFC 2616 sec 2.2
+ * which has been replaced by the token definition in RFC 7230 appendix B.
  *
- * field-content = field-vchar [ 1*( SP / HTAB ) field-vchar ]
- * field-vchar   = VCHAR / obs-text
- * obs-text      = %x80-FF
+ * cookie-name       = token
+ * token             = 1*tchar
+ * tchar             = "!" / "#" / "$" / "%" / "&" / "'" /
+ *                     "*" / "+" / "-" / "." / "^" / "_" /
+ *                     "`" / "|" / "~" / DIGIT / ALPHA
  */
 
-var fieldContentRegExp = /^[\u0009\u0020-\u007e\u0080-\u00ff]+$/;
+var cookieNameRegExp = /^[!#$%&'*+\-.^_`|~0-9A-Za-z]+$/;
+
+/**
+ * RegExp to match cookie-value in RFC 6265 sec 4.1.1
+ *
+ * cookie-value      = *cookie-octet / ( DQUOTE *cookie-octet DQUOTE )
+ * cookie-octet      = %x21 / %x23-2B / %x2D-3A / %x3C-5B / %x5D-7E
+ *                     ; US-ASCII characters excluding CTLs,
+ *                     ; whitespace DQUOTE, comma, semicolon,
+ *                     ; and backslash
+ */
+
+var cookieValueRegExp = /^("?)[\u0021\u0023-\u002B\u002D-\u003A\u003C-\u005B\u005D-\u007E]*\1$/;
+
+/**
+ * RegExp to match domain-value in RFC 6265 sec 4.1.1
+ *
+ * domain-value      = <subdomain>
+ *                     ; defined in [RFC1034], Section 3.5, as
+ *                     ; enhanced by [RFC1123], Section 2.1
+ * <subdomain>       = <label> | <subdomain> "." <label>
+ * <label>           = <let-dig> [ [ <ldh-str> ] <let-dig> ]
+ *                     Labels must be 63 characters or less.
+ *                     'let-dig' not 'letter' in the first char, per RFC1123
+ * <ldh-str>         = <let-dig-hyp> | <let-dig-hyp> <ldh-str>
+ * <let-dig-hyp>     = <let-dig> | "-"
+ * <let-dig>         = <letter> | <digit>
+ * <letter>          = any one of the 52 alphabetic characters A through Z in
+ *                     upper case and a through z in lower case
+ * <digit>           = any one of the ten digits 0 through 9
+ */
+
+var domainValueRegExp = /^([a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?)([.][a-z0-9]([a-z0-9-]{0,61}[a-z0-9])?)*$/i;
+
+/**
+ * RegExp to match path-value in RFC 6265 sec 4.1.1
+ *
+ * path-value        = <any CHAR except CTLs or ";">
+ * CHAR              = %x01-7F
+ *                     ; defined in RFC 5234 appendix B.1
+ */
+
+var pathValueRegExp = /^[\u0020-\u003A\u003D-\u007E]*$/;
 
 /**
  * Parse a cookie header.
@@ -116,13 +162,13 @@ function serialize(name, val, options) {
     throw new TypeError('option encode is invalid');
   }
 
-  if (!fieldContentRegExp.test(name)) {
+  if (!cookieNameRegExp.test(name)) {
     throw new TypeError('argument name is invalid');
   }
 
   var value = enc(val);
 
-  if (value && !fieldContentRegExp.test(value)) {
+  if (value && !cookieValueRegExp.test(value)) {
     throw new TypeError('argument val is invalid');
   }
 
@@ -139,7 +185,7 @@ function serialize(name, val, options) {
   }
 
   if (opt.domain) {
-    if (!fieldContentRegExp.test(opt.domain)) {
+    if (!domainValueRegExp.test(opt.domain)) {
       throw new TypeError('option domain is invalid');
     }
 
@@ -147,7 +193,7 @@ function serialize(name, val, options) {
   }
 
   if (opt.path) {
-    if (!fieldContentRegExp.test(opt.path)) {
+    if (!pathValueRegExp.test(opt.path)) {
       throw new TypeError('option path is invalid');
     }
 
diff --git a/test/serialize.js b/test/serialize.js
index 80d0c48..0f8a6df 100644
--- a/test/serialize.js
+++ b/test/serialize.js
@@ -20,6 +20,7 @@ describe('cookie.serialize(name, value)', function () {
   it('should throw for invalid name', function () {
     assert.throws(cookie.serialize.bind(cookie, 'foo\n', 'bar'), /argument name is invalid/)
     assert.throws(cookie.serialize.bind(cookie, 'foo\u280a', 'bar'), /argument name is invalid/)
+    assert.throws(cookie.serialize.bind(cookie, 'foo bar', 'bar'), /argument name is invalid/)
   })
 })
 
@@ -52,6 +53,9 @@ describe('cookie.serialize(name, value, options)', function () {
       assert.throws(cookie.serialize.bind(cookie, 'foo', '+ \n', {
         encode: function (v) { return v }
       }), /argument val is invalid/)
+      assert.throws(cookie.serialize.bind(cookie, 'foo', 'foo bar', {
+        encode: function (v) { return v }
+      }), /argument val is invalid/)
     })
   })
 

From c679cccf7be16cb8c9a169487d20f847cff29017 Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Tue, 1 Oct 2024 16:15:09 -0700
Subject: [PATCH 04/14] Fix CI

---
 .github/workflows/ci.yml | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3469d1e..9da9752 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -105,39 +105,50 @@ jobs:
         - name: Node.js 10.x
           node-version: "10.24"
           npm-i: mocha@8.4.0
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 11.x
           node-version: "11.15"
           npm-i: mocha@8.4.0
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 12.x
           node-version: "12.22"
           npm-i: mocha@9.2.2
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 13.x
           node-version: "13.14"
           npm-i: mocha@9.2.2
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 14.x
           node-version: "14.21"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 15.x
           node-version: "15.14"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 16.x
           node-version: "16.20"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 17.x
           node-version: "17.9"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 18.x
           node-version: "18.18"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 19.x
           node-version: "19.9"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 20.x
           node-version: "20.9"
+          npm-rm: beautify-benchmark benchmark top-sites
 
         - name: Node.js 21.x
           node-version: "21.1"

From 927d48a18fc82828d3726e18927003db330247bb Mon Sep 17 00:00:00 2001
From: proudparrot2 <knowing.discos0e@icloud.com>
Date: Wed, 2 Oct 2024 16:11:45 -0500
Subject: [PATCH 05/14] Add `main` to `package.json` (#166)

---
 package.json | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package.json b/package.json
index 0c3f006..44227a0 100644
--- a/package.json
+++ b/package.json
@@ -29,6 +29,7 @@
     "SECURITY.md",
     "index.js"
   ],
+  "main": "index.js",
   "engines": {
     "node": ">= 0.6"
   },

From 47917c9c2c56887c53d68e23159a7e1c3f7cb958 Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 14:56:24 -0700
Subject: [PATCH 06/14] Iterate whitespace for perf (#170)

---
 index.js      | 55 +++++++++++++++++++++++++++++++++++++--------------
 test/parse.js | 17 +++++++++++++++-
 2 files changed, 56 insertions(+), 16 deletions(-)

diff --git a/index.js b/index.js
index 6fe633d..0eeccaf 100644
--- a/index.js
+++ b/index.js
@@ -95,40 +95,49 @@ function parse(str, options) {
     throw new TypeError('argument str must be a string');
   }
 
-  var obj = {}
+  var obj = {};
   var opt = options || {};
   var dec = opt.decode || decode;
 
-  var index = 0
-  while (index < str.length) {
-    var eqIdx = str.indexOf('=', index)
+  var index = 0;
+  var eqIdx = 0;
+  var endIdx = 0;
+  var len = str.length;
+  var max = len - 2;
+
+  while (index < max) {
+    eqIdx = str.indexOf('=', index);
 
     // no more cookie pairs
     if (eqIdx === -1) {
-      break
+      break;
     }
 
-    var endIdx = str.indexOf(';', index)
+    endIdx = str.indexOf(';', index);
 
     if (endIdx === -1) {
-      endIdx = str.length
-    } else if (endIdx < eqIdx) {
+      endIdx = len;
+    } else if (eqIdx > endIdx) {
       // backtrack on prior semicolon
-      index = str.lastIndexOf(';', eqIdx - 1) + 1
-      continue
+      index = str.lastIndexOf(';', eqIdx - 1) + 1;
+      continue;
     }
 
-    var key = str.slice(index, eqIdx).trim()
+    var keyStartIdx = startIndex(str, index, eqIdx);
+    var keyEndIdx = endIndex(str, eqIdx, keyStartIdx);
+    var key = str.slice(keyStartIdx, keyEndIdx);
 
     // only assign once
     if (undefined === obj[key]) {
-      var val = str.slice(eqIdx + 1, endIdx).trim()
+      var valStartIdx = startIndex(str, eqIdx + 1, endIdx);
+      var valEndIdx = endIndex(str, endIdx, valStartIdx);
 
-      // quoted values
-      if (val.charCodeAt(0) === 0x22) {
-        val = val.slice(1, -1)
+      if (str.charCodeAt(valStartIdx) === 0x22 /* " */ && str.charCodeAt(valEndIdx - 1) === 0x22 /* " */) {
+        valStartIdx++;
+        valEndIdx--;
       }
 
+      var val = str.slice(valStartIdx, valEndIdx);
       obj[key] = tryDecode(val, dec);
     }
 
@@ -138,6 +147,22 @@ function parse(str, options) {
   return obj;
 }
 
+function startIndex(str, index, max) {
+  do {
+    var code = str.charCodeAt(index);
+    if (code !== 0x20 /*   */ && code !== 0x09 /* \t */) return index;
+  } while (++index < max);
+  return max;
+}
+
+function endIndex(str, index, min) {
+  while (index > min) {
+    var code = str.charCodeAt(--index);
+    if (code !== 0x20 /*   */ && code !== 0x09 /* \t */) return index + 1;
+  }
+  return min;
+}
+
 /**
  * Serialize data into a cookie header.
  *
diff --git a/test/parse.js b/test/parse.js
index 76229ca..c11b4fc 100644
--- a/test/parse.js
+++ b/test/parse.js
@@ -24,7 +24,7 @@ describe('cookie.parse(str)', function () {
   })
 
   it('should parse cookie with empty value', function () {
-    assert.deepEqual(cookie.parse('foo= ; bar='), { foo: '', bar: '' })
+    assert.deepEqual(cookie.parse('foo=; bar='), { foo: '', bar: '' })
   })
 
   it('should URL-decode values', function () {
@@ -34,6 +34,21 @@ describe('cookie.parse(str)', function () {
     assert.deepEqual(cookie.parse('email=%20%22%2c%3b%2f'), { email: ' ",;/' })
   })
 
+  it('should parse quoted values', function () {
+    assert.deepEqual(cookie.parse('foo="bar"'), { foo: 'bar' })
+    assert.deepEqual(cookie.parse('foo=" a b c "'), { foo: ' a b c ' })
+  })
+
+  it('should trim whitespace around key and value', function () {
+    assert.deepEqual(cookie.parse('  foo  =  "bar"  '), { foo: 'bar' })
+    assert.deepEqual(cookie.parse('  foo  =  bar  ;  fizz  =  buzz  '), { foo: 'bar', fizz: 'buzz' })
+    assert.deepEqual(cookie.parse(' foo = " a b c " '), { foo: ' a b c ' })
+    assert.deepEqual(cookie.parse(' = bar '), { '': 'bar' })
+    assert.deepEqual(cookie.parse(' foo = '), { foo: '' })
+    assert.deepEqual(cookie.parse('   =   '), { '': '' })
+    assert.deepEqual(cookie.parse('\tfoo\t=\tbar\t'), { foo: 'bar' })
+  })
+
   it('should return original value on escape error', function () {
     assert.deepEqual(cookie.parse('foo=%1;bar=bar'), { foo: '%1', bar: 'bar' })
   })

From ca70da4ddccf7daab7ad7e86e8c83d6a0123ba73 Mon Sep 17 00:00:00 2001
From: Trey McCallie <162155285+hdtmccallie@users.noreply.github.com>
Date: Wed, 2 Oct 2024 14:56:49 -0700
Subject: [PATCH 07/14] test(serialize): additional tests for name, domain and
 path RFC validations (#171)

---
 test/serialize.js | 145 ++++++++++++++++++++++++++++++++++++++++------
 1 file changed, 126 insertions(+), 19 deletions(-)

diff --git a/test/serialize.js b/test/serialize.js
index 0f8a6df..332f7cd 100644
--- a/test/serialize.js
+++ b/test/serialize.js
@@ -17,24 +17,98 @@ describe('cookie.serialize(name, value)', function () {
     assert.equal(cookie.serialize('foo', ''), 'foo=')
   })
 
+  it('should serialize valid name', function () {
+    var validNames = [
+      'foo',
+      'foo!bar',
+      'foo#bar',
+      'foo$bar',
+      "foo'bar",
+      'foo*bar',
+      'foo+bar',
+      'foo-bar',
+      'foo.bar',
+      'foo^bar',
+      'foo_bar',
+      'foo`bar',
+      'foo|bar',
+      'foo~bar',
+      'foo7bar',
+    ];
+
+    validNames.forEach((name) => {
+      assert.equal(cookie.serialize(name, 'baz'), `${name}=baz`, `Expected serialized value for name: "${name}"`);
+    });
+  });
+
   it('should throw for invalid name', function () {
-    assert.throws(cookie.serialize.bind(cookie, 'foo\n', 'bar'), /argument name is invalid/)
-    assert.throws(cookie.serialize.bind(cookie, 'foo\u280a', 'bar'), /argument name is invalid/)
-    assert.throws(cookie.serialize.bind(cookie, 'foo bar', 'bar'), /argument name is invalid/)
-  })
-})
+    var invalidNames = [
+      'foo\n',
+      'foo\u280a',
+      'foo/foo',
+      'foo,foo',
+      'foo;foo',
+      'foo@foo',
+      'foo[foo]',
+      'foo?foo',
+      'foo:foo',
+      'foo!foo',
+      'foo{foo}',
+      'foo foo',
+      'foo\tfoo',
+      'foo"foo',
+      'foo<script>foo'
+    ];
+
+    invalidNames.forEach((name) => {
+      assert.throws(
+        cookie.serialize.bind(cookie, name, 'bar'),
+        /argument name is invalid/,
+        `Expected an error for invalid name: "${name}"`
+      );
+    });
+  });
+});
 
 describe('cookie.serialize(name, value, options)', function () {
   describe('with "domain" option', function () {
-    it('should serialize domain', function () {
-      assert.equal(cookie.serialize('foo', 'bar', { domain: 'example.com' }),
-        'foo=bar; Domain=example.com')
-    })
 
-    it('should throw for invalid value', function () {
-      assert.throws(cookie.serialize.bind(cookie, 'foo', 'bar', { domain: 'example.com\n' }),
-        /option domain is invalid/)
-    })
+    it('should serialize valid domain', function () {
+      const validDomains = [
+        'example.com',
+        'sub.example.com',
+        'my-site.org',
+        'localhost'
+      ];
+
+      validDomains.forEach((domain) => {
+        assert.equal(
+          cookie.serialize('foo', 'bar', { domain }),
+          `foo=bar; Domain=${domain}`,
+          `Expected serialized value for domain: "${domain}"`
+        );
+      });
+    });
+
+    it('should throw for invalid domain', function () {
+      const invalidDomains = [
+        'example.com\n',
+        'sub.example.com\u0000',
+        'my site.org',
+        'domain..com',
+        '.example.com',
+        'example.com; Path=/',
+        'example.com /* inject a comment */'
+      ];
+
+      invalidDomains.forEach((domain) => {
+        assert.throws(
+          cookie.serialize.bind(cookie, 'foo', 'bar', { domain }),
+          /option domain is invalid/,
+          `Expected an error for invalid domain: "${domain}"`
+        );
+      });
+    });
   })
 
   describe('with "encode" option', function () {
@@ -133,14 +207,47 @@ describe('cookie.serialize(name, value, options)', function () {
 
   describe('with "path" option', function () {
     it('should serialize path', function () {
-      assert.equal(cookie.serialize('foo', 'bar', { path: '/' }), 'foo=bar; Path=/')
-    })
+      const validPaths = [
+        '/',
+        '/login',
+        '/foo.bar/baz',
+        '/foo-bar',
+        '/foo=bar?baz',
+        '/foo"bar"',
+        '/../foo/bar',
+        '../foo/',
+        './'
+      ];
+
+      validPaths.forEach((path) => {
+        assert.equal(
+          cookie.serialize('foo', 'bar', { path }),
+          `foo=bar; Path=${path}`,
+          `Expected serialized value for path: "${path}"`
+        );
+      });
+    });
 
     it('should throw for invalid value', function () {
-      assert.throws(cookie.serialize.bind(cookie, 'foo', 'bar', { path: '/\n' }),
-        /option path is invalid/)
-    })
-  })
+      const invalidPaths = [
+        '/\n',
+        '/foo\u0000',
+        '/foo bar',
+        '/path/with\rnewline',
+        '/path\\with\\backslash',
+        '/; Path=/sensitive-data',
+        '/login"><script>alert(1)</script>'
+      ];
+
+      invalidPaths.forEach((path) => {
+        assert.throws(
+          cookie.serialize.bind(cookie, 'foo', 'bar', { path }),
+          /option path is invalid/,
+          `Expected an error for invalid path: "${path}"`
+        );
+      });
+    });
+  });
 
   describe('with "priority" option', function () {
     it('should throw on invalid priority', function () {

From 6bb701f14e59c5e768933bfae9b578db4ed26c6e Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 14:57:17 -0700
Subject: [PATCH 08/14] Remove failing scorecard

---
 .github/workflows/scorecard.yml | 72 ---------------------------------
 1 file changed, 72 deletions(-)
 delete mode 100644 .github/workflows/scorecard.yml

diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml
deleted file mode 100644
index 3bfd85a..0000000
--- a/.github/workflows/scorecard.yml
+++ /dev/null
@@ -1,72 +0,0 @@
-# This workflow uses actions that are not certified by GitHub. They are provided
-# by a third-party and are governed by separate terms of service, privacy
-# policy, and support documentation.
-
-name: Scorecard supply-chain security
-on:
-  # For Branch-Protection check. Only the default branch is supported. See
-  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#branch-protection
-  branch_protection_rule:
-  # To guarantee Maintained check is occasionally updated. See
-  # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained
-  schedule:
-    - cron: '16 21 * * 1'
-  push:
-    branches: [ "master" ]
-
-# Declare default permissions as read only.
-permissions: read-all
-
-jobs:
-  analysis:
-    name: Scorecard analysis
-    runs-on: ubuntu-latest
-    permissions:
-      # Needed to upload the results to code-scanning dashboard.
-      security-events: write
-      # Needed to publish results and get a badge (see publish_results below).
-      id-token: write
-      # Uncomment the permissions below if installing in a private repository.
-      # contents: read
-      # actions: read
-
-    steps:
-      - name: "Checkout code"
-        uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0
-        with:
-          persist-credentials: false
-
-      - name: "Run analysis"
-        uses: ossf/scorecard-action@99c53751e09b9529366343771cc321ec74e9bd3d # v2.0.6
-        with:
-          results_file: results.sarif
-          results_format: sarif
-          # (Optional) "write" PAT token. Uncomment the `repo_token` line below if:
-          # - you want to enable the Branch-Protection check on a *public* repository, or
-          # - you are installing Scorecard on a *private* repository
-          # To create the PAT, follow the steps in https://github.com/ossf/scorecard-action#authentication-with-pat.
-          # repo_token: ${{ secrets.SCORECARD_TOKEN }}
-
-          # Public repositories:
-          #   - Publish results to OpenSSF REST API for easy access by consumers
-          #   - Allows the repository to include the Scorecard badge.
-          #   - See https://github.com/ossf/scorecard-action#publishing-results.
-          # For private repositories:
-          #   - `publish_results` will always be set to `false`, regardless
-          #     of the value entered here.
-          publish_results: true
-
-      # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
-      # format to the repository Actions tab.
-      - name: "Upload artifact"
-        uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
-        with:
-          name: SARIF file
-          path: results.sarif
-          retention-days: 5
-
-      # Upload the results to GitHub's code scanning dashboard.
-      - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@2f93e4319b2f04a2efc38fa7f78bd681bc3f7b2f # v2.23.2
-        with:
-          sarif_file: results.sarif
\ No newline at end of file

From d6f39b0aab5521a8b118b466a515fd6eb0b9f65e Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 15:21:10 -0700
Subject: [PATCH 09/14] Fix tests for old node

---
 test/serialize.js | 46 +++++++++++++++++++++-------------------------
 1 file changed, 21 insertions(+), 25 deletions(-)

diff --git a/test/serialize.js b/test/serialize.js
index 332f7cd..be84595 100644
--- a/test/serialize.js
+++ b/test/serialize.js
@@ -36,8 +36,8 @@ describe('cookie.serialize(name, value)', function () {
       'foo7bar',
     ];
 
-    validNames.forEach((name) => {
-      assert.equal(cookie.serialize(name, 'baz'), `${name}=baz`, `Expected serialized value for name: "${name}"`);
+    validNames.forEach(function (name) {
+      assert.equal(cookie.serialize(name, 'baz'), name + '=baz');
     });
   });
 
@@ -52,7 +52,6 @@ describe('cookie.serialize(name, value)', function () {
       'foo[foo]',
       'foo?foo',
       'foo:foo',
-      'foo!foo',
       'foo{foo}',
       'foo foo',
       'foo\tfoo',
@@ -60,11 +59,11 @@ describe('cookie.serialize(name, value)', function () {
       'foo<script>foo'
     ];
 
-    invalidNames.forEach((name) => {
+    invalidNames.forEach(function (name) {
       assert.throws(
         cookie.serialize.bind(cookie, name, 'bar'),
         /argument name is invalid/,
-        `Expected an error for invalid name: "${name}"`
+        'Expected an error for invalid name: ' + name
       );
     });
   });
@@ -74,24 +73,23 @@ describe('cookie.serialize(name, value, options)', function () {
   describe('with "domain" option', function () {
 
     it('should serialize valid domain', function () {
-      const validDomains = [
+      var validDomains = [
         'example.com',
         'sub.example.com',
         'my-site.org',
         'localhost'
       ];
 
-      validDomains.forEach((domain) => {
+      validDomains.forEach(function (domain) {
         assert.equal(
-          cookie.serialize('foo', 'bar', { domain }),
-          `foo=bar; Domain=${domain}`,
-          `Expected serialized value for domain: "${domain}"`
+          cookie.serialize('foo', 'bar', { domain: domain }),
+          'foo=bar; Domain=' + domain
         );
       });
     });
 
     it('should throw for invalid domain', function () {
-      const invalidDomains = [
+      var invalidDomains = [
         'example.com\n',
         'sub.example.com\u0000',
         'my site.org',
@@ -101,11 +99,11 @@ describe('cookie.serialize(name, value, options)', function () {
         'example.com /* inject a comment */'
       ];
 
-      invalidDomains.forEach((domain) => {
+      invalidDomains.forEach(function (domain) {
         assert.throws(
-          cookie.serialize.bind(cookie, 'foo', 'bar', { domain }),
+          cookie.serialize.bind(cookie, 'foo', 'bar', { domain: domain }),
           /option domain is invalid/,
-          `Expected an error for invalid domain: "${domain}"`
+          'Expected an error for invalid domain: ' + domain
         );
       });
     });
@@ -207,7 +205,7 @@ describe('cookie.serialize(name, value, options)', function () {
 
   describe('with "path" option', function () {
     it('should serialize path', function () {
-      const validPaths = [
+      var validPaths = [
         '/',
         '/login',
         '/foo.bar/baz',
@@ -219,31 +217,29 @@ describe('cookie.serialize(name, value, options)', function () {
         './'
       ];
 
-      validPaths.forEach((path) => {
+      validPaths.forEach(function (path) {
         assert.equal(
-          cookie.serialize('foo', 'bar', { path }),
-          `foo=bar; Path=${path}`,
-          `Expected serialized value for path: "${path}"`
+          cookie.serialize('foo', 'bar', { path: path }),
+          'foo=bar; Path=' + path,
+          'Expected serialized value for path: ' + path
         );
       });
     });
 
     it('should throw for invalid value', function () {
-      const invalidPaths = [
+      var invalidPaths = [
         '/\n',
         '/foo\u0000',
-        '/foo bar',
         '/path/with\rnewline',
-        '/path\\with\\backslash',
         '/; Path=/sensitive-data',
         '/login"><script>alert(1)</script>'
       ];
 
-      invalidPaths.forEach((path) => {
+      invalidPaths.forEach(function (path) {
         assert.throws(
-          cookie.serialize.bind(cookie, 'foo', 'bar', { path }),
+          cookie.serialize.bind(cookie, 'foo', 'bar', { path: path }),
           /option path is invalid/,
-          `Expected an error for invalid path: "${path}"`
+          'Expected an error for invalid path: ' + path
         );
       });
     });

From 9e7ca51ade4b325307eedd6b4dec190983e9e2cc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacob=20Gro=C3=9F?= <kurtextrem@gmail.com>
Date: Thu, 3 Oct 2024 00:25:59 +0200
Subject: [PATCH 10/14] perf(parse): cache length, return early (#144)

---
 benchmark/parse-top.json |  3 ++-
 index.js                 | 15 ++++++++-------
 test/parse.js            |  4 ++++
 3 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/benchmark/parse-top.json b/benchmark/parse-top.json
index 0530aa9..125b695 100644
--- a/benchmark/parse-top.json
+++ b/benchmark/parse-top.json
@@ -12,5 +12,6 @@
   "support.google.com": "UUU=000=l0llUUlUllU0UlllU0U0U0UlU-Ulll0lUlllU0UUllUUlUUUlllllUUUU-UUllUllU0lUU0U0U00lU0UUlUl0l0lUUlUUUUl0lUU0UUllUlUlUUlUlUUUU0ll0l0UU0lllU0lllUUUU0U0lU0U00l0Ul0UlU-U0UllU00lUUl0U; UUU=000=l0llUUlUllU0UlllU0U0U0UlU-Ulll0lUlllU0UUllUUlUUUlllllUUUU-UUllUllU0lUU0U0U00lU0UUlUl0l0lUUlUUUUl0lUU0UUllUlUlUUlUlUUUU0ll0l0UU0lllU0lllUUUU0U0lU0U00l0Ul0UlU-U0UllU00lUUl0U",
   "www.google.com": "0U_UUU=0000-00-00-00; UUU=Ullll0Ullll0U0llUllU00U_lllll0lUUlUl0UllUlUUl0lUlUUUl00UUl; UUU=000=lUU0U0U0U0UllUUUlUUlUUU_UlUll_l0U0UU00lUlUlUlllllUUUl00UllllUU_0ll0UllUllUUU-UUUlllU0UlUlUllUlUllUll00UllU0U00llUUl0lU00lUlUUlllUl_U00UUlU0UU0UllUlUU0lUUlUUUl00lUUlUUUU0ll",
   "youtu.be": "UUU=0; UUU=ll0UU-l0lUl; UUUUUUU_UUUU0_UUUU=0_llUUlUllU; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22",
-  "youtube.com": "UUU=0; UUU=l0_UlUUUlUl; UUUUUUU_UUUU0_UUUU=UUUUlUUUlll; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22"
+  "youtube.com": "UUU=0; UUU=l0_UlUUUlUl; UUUUUUU_UUUU0_UUUU=UUUUlUUUlll; UUUUUUU_UUUUUUU_UUUUUUUU=UlUUUlUUUlU%22",
+  "example.com": ""
 }
diff --git a/index.js b/index.js
index 0eeccaf..3e5162a 100644
--- a/index.js
+++ b/index.js
@@ -96,16 +96,17 @@ function parse(str, options) {
   }
 
   var obj = {};
-  var opt = options || {};
-  var dec = opt.decode || decode;
-
+  var len = str.length;
+  // RFC 6265 sec 4.1.1, RFC 2616 2.2 defines a cookie name consists of one char minimum, plus '='.
+  var max = len - 2;
+  if (max < 0) return obj;
+  
+  var dec = (options && options.decode) || decode;
   var index = 0;
   var eqIdx = 0;
   var endIdx = 0;
-  var len = str.length;
-  var max = len - 2;
 
-  while (index < max) {
+  do {
     eqIdx = str.indexOf('=', index);
 
     // no more cookie pairs
@@ -142,7 +143,7 @@ function parse(str, options) {
     }
 
     index = endIdx + 1
-  }
+  } while (index < max);
 
   return obj;
 }
diff --git a/test/parse.js b/test/parse.js
index c11b4fc..f223b16 100644
--- a/test/parse.js
+++ b/test/parse.js
@@ -27,6 +27,10 @@ describe('cookie.parse(str)', function () {
     assert.deepEqual(cookie.parse('foo=; bar='), { foo: '', bar: '' })
   })
 
+  it('should parse cookie with minimum length', function () {
+    assert.deepEqual(cookie.parse('f='), { f: '' })
+  })
+
   it('should URL-decode values', function () {
     assert.deepEqual(cookie.parse('foo="bar=123456789&name=Magic+Mouse"'),
       { foo: 'bar=123456789&name=Magic+Mouse' })

From 51968f94b5e820adeceef505539fa193ffe2d105 Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 15:32:30 -0700
Subject: [PATCH 11/14] Skip isNaN

---
 index.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/index.js b/index.js
index 3e5162a..56ed1e6 100644
--- a/index.js
+++ b/index.js
@@ -100,7 +100,7 @@ function parse(str, options) {
   // RFC 6265 sec 4.1.1, RFC 2616 2.2 defines a cookie name consists of one char minimum, plus '='.
   var max = len - 2;
   if (max < 0) return obj;
-  
+
   var dec = (options && options.decode) || decode;
   var index = 0;
   var eqIdx = 0;
@@ -203,7 +203,7 @@ function serialize(name, val, options) {
   if (null != opt.maxAge) {
     var maxAge = opt.maxAge - 0;
 
-    if (isNaN(maxAge) || !isFinite(maxAge)) {
+    if (!isFinite(maxAge)) {
       throw new TypeError('option maxAge is invalid')
     }
 

From a5d591ce8447dd63821779724f96ad3c774c8579 Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 15:56:44 -0700
Subject: [PATCH 12/14] Migrate history to GitHub releases

---
 HISTORY.md | 147 -----------------------------------------------------
 1 file changed, 147 deletions(-)
 delete mode 100644 HISTORY.md

diff --git a/HISTORY.md b/HISTORY.md
deleted file mode 100644
index 41ae4b0..0000000
--- a/HISTORY.md
+++ /dev/null
@@ -1,147 +0,0 @@
-0.6.0 / 2023-11-06
-==================
-
-  * Add `partitioned` option
-
-0.5.0 / 2022-04-11
-==================
-
-  * Add `priority` option
-  * Fix `expires` option to reject invalid dates
-  * perf: improve default decode speed
-  * perf: remove slow string split in parse
-
-0.4.2 / 2022-02-02
-==================
-
-  * perf: read value only when assigning in parse
-  * perf: remove unnecessary regexp in parse
-
-0.4.1 / 2020-04-21
-==================
-
-  * Fix `maxAge` option to reject invalid values
-
-0.4.0 / 2019-05-15
-==================
-
-  * Add `SameSite=None` support
-
-0.3.1 / 2016-05-26
-==================
-
-  * Fix `sameSite: true` to work with draft-7 clients
-    - `true` now sends `SameSite=Strict` instead of `SameSite`
-
-0.3.0 / 2016-05-26
-==================
-
-  * Add `sameSite` option
-    - Replaces `firstPartyOnly` option, never implemented by browsers
-  * Improve error message when `encode` is not a function
-  * Improve error message when `expires` is not a `Date`
-
-0.2.4 / 2016-05-20
-==================
-
-  * perf: enable strict mode
-  * perf: use for loop in parse
-  * perf: use string concatenation for serialization
-
-0.2.3 / 2015-10-25
-==================
-
-  * Fix cookie `Max-Age` to never be a floating point number
-
-0.2.2 / 2015-09-17
-==================
-
-  * Fix regression when setting empty cookie value
-    - Ease the new restriction, which is just basic header-level validation
-  * Fix typo in invalid value errors
-
-0.2.1 / 2015-09-17
-==================
-
-  * Throw on invalid values provided to `serialize`
-    - Ensures the resulting string is a valid HTTP header value
-
-0.2.0 / 2015-08-13
-==================
-
-  * Add `firstPartyOnly` option
-  * Throw better error for invalid argument to parse
-  * perf: hoist regular expression
-
-0.1.5 / 2015-09-17
-==================
-
-  * Fix regression when setting empty cookie value
-    - Ease the new restriction, which is just basic header-level validation
-  * Fix typo in invalid value errors
-
-0.1.4 / 2015-09-17
-==================
-
-  * Throw better error for invalid argument to parse
-  * Throw on invalid values provided to `serialize`
-    - Ensures the resulting string is a valid HTTP header value
-
-0.1.3 / 2015-05-19
-==================
-
-  * Reduce the scope of try-catch deopt
-  * Remove argument reassignments
-
-0.1.2 / 2014-04-16
-==================
-
-  * Remove unnecessary files from npm package
-
-0.1.1 / 2014-02-23
-==================
-
-  * Fix bad parse when cookie value contained a comma
-  * Fix support for `maxAge` of `0`
-
-0.1.0 / 2013-05-01
-==================
-
-  * Add `decode` option
-  * Add `encode` option
-
-0.0.6 / 2013-04-08
-==================
-
-  * Ignore cookie parts missing `=`
-
-0.0.5 / 2012-10-29
-==================
-
-  * Return raw cookie value if value unescape errors
-
-0.0.4 / 2012-06-21
-==================
-
-  * Use encode/decodeURIComponent for cookie encoding/decoding
-    - Improve server/client interoperability
-
-0.0.3 / 2012-06-06
-==================
-
-  * Only escape special characters per the cookie RFC
-
-0.0.2 / 2012-06-01
-==================
-
-  * Fix `maxAge` option to not throw error
-
-0.0.1 / 2012-05-28
-==================
-
-  * Add more tests
-
-0.0.0 / 2012-05-28
-==================
-
-  * Initial release

From 5f02ca87688481dbcf155e49ca8b61732f30e542 Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 15:56:44 -0700
Subject: [PATCH 13/14] Migrate history to GitHub releases

---
 package.json               |  3 +-
 scripts/version-history.js | 63 --------------------------------------
 2 files changed, 1 insertion(+), 65 deletions(-)
 delete mode 100644 scripts/version-history.js

diff --git a/package.json b/package.json
index 44227a0..7f3daa8 100644
--- a/package.json
+++ b/package.json
@@ -39,7 +39,6 @@
     "test": "mocha --reporter spec --bail --check-leaks test/",
     "test-ci": "nyc --reporter=lcov --reporter=text npm test",
     "test-cov": "nyc --reporter=html --reporter=text npm test",
-    "update-bench": "node scripts/update-benchmark.js",
-    "version": "node scripts/version-history.js && git add HISTORY.md"
+    "update-bench": "node scripts/update-benchmark.js"
   }
 }
diff --git a/scripts/version-history.js b/scripts/version-history.js
deleted file mode 100644
index c58268a..0000000
--- a/scripts/version-history.js
+++ /dev/null
@@ -1,63 +0,0 @@
-'use strict'
-
-var fs = require('fs')
-var path = require('path')
-
-var HISTORY_FILE_PATH = path.join(__dirname, '..', 'HISTORY.md')
-var MD_HEADER_REGEXP = /^====*$/
-var VERSION = process.env.npm_package_version
-var VERSION_PLACEHOLDER_REGEXP = /^(?:unreleased|(\d+\.)+x)$/
-
-var historyFileLines = fs.readFileSync(HISTORY_FILE_PATH, 'utf-8').split('\n')
-
-if (!MD_HEADER_REGEXP.test(historyFileLines[1])) {
-  console.error('Missing header in HISTORY.md')
-  process.exit(1)
-}
-
-if (!VERSION_PLACEHOLDER_REGEXP.test(historyFileLines[0])) {
-  console.error('Missing placeholder version in HISTORY.md')
-  process.exit(1)
-}
-
-if (historyFileLines[0].indexOf('x') !== -1) {
-  var versionCheckRegExp = new RegExp('^' + historyFileLines[0].replace('x', '.+') + '$')
-
-  if (!versionCheckRegExp.test(VERSION)) {
-    console.error('Version %s does not match placeholder %s', VERSION, historyFileLines[0])
-    process.exit(1)
-  }
-}
-
-historyFileLines[0] = VERSION + ' / ' + getLocaleDate()
-historyFileLines[1] = repeat('=', historyFileLines[0].length)
-
-fs.writeFileSync(HISTORY_FILE_PATH, historyFileLines.join('\n'))
-
-function getLocaleDate () {
-  var now = new Date()
-
-  return zeroPad(now.getFullYear(), 4) + '-' +
-    zeroPad(now.getMonth() + 1, 2) + '-' +
-    zeroPad(now.getDate(), 2)
-}
-
-function repeat (str, length) {
-  var out = ''
-
-  for (var i = 0; i < length; i++) {
-    out += str
-  }
-
-  return out
-}
-
-function zeroPad (number, length) {
-  var num = number.toString()
-
-  while (num.length < length) {
-    num = '0' + num
-  }
-
-  return num
-}

From ab057d6c06b94a7b1e3358e69a685ae49c97b627 Mon Sep 17 00:00:00 2001
From: Blake Embrey <hello@blakeembrey.com>
Date: Wed, 2 Oct 2024 16:06:15 -0700
Subject: [PATCH 14/14] 0.7.0

---
 package.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package.json b/package.json
index 7f3daa8..df099d2 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "cookie",
   "description": "HTTP server cookie parsing and serialization",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "author": "Roman Shtylman <shtylman@gmail.com>",
   "contributors": [
     "Douglas Christopher Wilson <doug@somethingdoug.com>"