Remove unnecessary explicit default loc='best' in legend()

timhoffm · timhoffm · commit 0d0bde4147d6 · 2018-05-07T01:26:40.000+02:00
diff --git a/examples/api/sankey_basics.py b/examples/api/sankey_basics.py
@@ -91,7 +91,7 @@
            orientations=[-1, -1, -1], prior=0, connect=(0, 0))
 diagrams = sankey.finish()
 diagrams[-1].patch.set_hatch('/')
-plt.legend(loc='best')
+plt.legend()
 
 ###############################################################################
 # Notice that only one connection is specified, but the systems form a
diff --git a/examples/recipes/transparent_legends.py b/examples/recipes/transparent_legends.py
@@ -9,10 +9,10 @@
 
   ax.legend(loc='upper right')
 
-Other times you don't know where your data is, and loc='best' will try
-and place the legend::
+Other times you don't know where your data is, and the default loc='best'
+will try and place the legend::
 
-  ax.legend(loc='best')
+  ax.legend()
 
 but still, your legend may overlap your data, and in these cases it's
 nice to make the legend frame transparent.
@@ -27,7 +27,7 @@
 ax.plot(np.random.rand(300), 's-', label='uniform distribution')
 ax.set_ylim(-3, 3)
 
-ax.legend(loc='best', fancybox=True, framealpha=0.5)
+ax.legend(fancybox=True, framealpha=0.5)
 ax.set_title('fancy, transparent legends')
 
 plt.show()
diff --git a/lib/matplotlib/pyplot.py b/lib/matplotlib/pyplot.py
@@ -2192,7 +2192,7 @@ def getname_val(identifier):
                 ax.set_xlabel('')
 
     if not subplots:
-        ax.legend(ynamelist, loc='best')
+        ax.legend(ynamelist)
 
     if xname=='date':
         fig.autofmt_xdate()
diff --git a/lib/matplotlib/tests/test_legend.py b/lib/matplotlib/tests/test_legend.py
@@ -40,7 +40,7 @@ def test_legend_auto1():
     x = np.arange(100)
     ax.plot(x, 50 - x, 'o', label='y=1')
     ax.plot(x, x - 50, 'o', label='y=-1')
-    ax.legend(loc='best')
+    ax.legend()
 
 
 @image_comparison(baseline_images=['legend_auto2'], remove_text=True)
@@ -51,7 +51,7 @@ def test_legend_auto2():
     x = np.arange(100)
     b1 = ax.bar(x, x, align='edge', color='m')
     b2 = ax.bar(x, x[::-1], align='edge', color='g')
-    ax.legend([b1[0], b2[0]], ['up', 'down'], loc='best')
+    ax.legend([b1[0], b2[0]], ['up', 'down'])
 
 
 @image_comparison(baseline_images=['legend_auto3'])
@@ -64,7 +64,7 @@ def test_legend_auto3():
     ax.plot(x, y, 'o-', label='line')
     ax.set_xlim(0.0, 1.0)
     ax.set_ylim(0.0, 1.0)
-    ax.legend(loc='best')
+    ax.legend()
 
 
 @image_comparison(baseline_images=['legend_various_labels'], remove_text=True)
@@ -75,7 +75,7 @@ def test_various_labels():
     ax.plot(np.arange(4), 'o', label=1)
     ax.plot(np.linspace(4, 4.1), 'o', label='Développés')
     ax.plot(np.arange(4, 1, -1), 'o', label='__nolegend__')
-    ax.legend(numpoints=1, loc='best')
+    ax.legend(numpoints=1)
 
 
 @image_comparison(baseline_images=['legend_labels_first'], extensions=['png'],
@@ -87,7 +87,7 @@ def test_labels_first():
     ax.plot(np.arange(10), '-o', label=1)
     ax.plot(np.ones(10)*5, ':x', label="x")
     ax.plot(np.arange(20, 10, -1), 'd', label="diamond")
-    ax.legend(loc='best', markerfirst=False)
+    ax.legend(markerfirst=False)
 
 
 @image_comparison(baseline_images=['legend_multiple_keys'], extensions=['png'],
@@ -371,7 +371,7 @@ def test_legend_stackplot():
     ax.stackplot(x, y1, y2, y3, labels=['y1', 'y2', 'y3'])
     ax.set_xlim((0, 10))
     ax.set_ylim((0, 70))
-    ax.legend(loc='best')
+    ax.legend()
 
 
 def test_cross_figure_patch_legend():
@@ -424,7 +424,7 @@ def test_not_covering_scatter():
     for n in range(3):
         plt.scatter([n], [n], color=colors[n])
 
-    plt.legend(['foo', 'foo', 'foo'], loc='best')
+    plt.legend(['foo', 'foo', 'foo'])
     plt.gca().set_xlim(-0.5, 2.2)
     plt.gca().set_ylim(-0.5, 2.2)
 
@@ -439,7 +439,7 @@ def test_not_covering_scatter_transform():
 
     plt.scatter([20], [10], transform=offset + plt.gca().transData)
 
-    plt.legend(['foo', 'bar'], loc='best')
+    plt.legend(['foo', 'bar'])
 
 
 def test_linecollection_scaled_dashes():
