Fix title position for polar plots

rcomer · rcomer · commit 604e2d8cc1e2 · 2024-12-27T20:16:22.000Z
diff --git a/lib/matplotlib/axes/_base.py b/lib/matplotlib/axes/_base.py
@@ -3068,9 +3068,8 @@ def _update_title_position(self, renderer):
         top = -np.inf
         for ax in axs:
             bb = None
-            xticklabel_top = any(tick.label2.get_visible() for tick in
-                                 [ax.xaxis.majorTicks[0], ax.xaxis.minorTicks[0]])
-            if (xticklabel_top or ax.xaxis.get_label_position() == 'top'):
+            if (ax.xaxis.get_ticks_position() in ['top', 'unknown'] or
+                    ax.xaxis.get_label_position() == 'top'):
                 bb = ax.xaxis.get_tightbbox(renderer)
             if bb is None:
                 # Extent of the outline for colorbars, of the axes otherwise.
diff --git a/lib/matplotlib/tests/test_polar.py b/lib/matplotlib/tests/test_polar.py
@@ -220,6 +220,21 @@ def test_polar_rlabel_position():
     ax.tick_params(rotation='auto')
 
 
+@mpl.style.context('default')
+def test_polar_title_position():
+    fig = plt.figure()
+    ax = fig.add_subplot(projection='polar')
+
+    t = ax.set_title('foo')
+    fig.draw_without_rendering()
+    default_position = t.get_position()
+
+    # With no x/theta tick labels, the title should be lower
+    ax.tick_params(labelbottom=False, labeltop=False)
+    fig.draw_without_rendering()
+    assert t.get_position()[1] < default_position[1]
+
+
 @image_comparison(['polar_theta_wedge'], style='default')
 def test_polar_theta_limits():
     r = np.arange(0, 3.0, 0.01)
