Selector: Don't rely on splice being present on input

mgol · mgol · commit 0829c177bf59 · 2022-10-03T23:10:57.000+02:00
Without this fix calling `jQuery.uniqueSort` on an array-like can result in: TypeError: results.splice is not a function at Function.jQuery.uniqueSort (https://code.jquery.com/jquery-git.js:664:12) at jQuery.fn.init.find (https://code.jquery.com/jquery-git.js:2394:27) at gocusihafe.js:3:4 Ref jquerygh-4986
diff --git a/src/selector.js b/src/selector.js
@@ -7,6 +7,7 @@ define( [
 	"./var/pop",
 	"./var/push",
 	"./var/sort",
+	"./var/splice",
 	"./var/whitespace",
 	"./var/rtrimCSS",
 	"./var/support",
@@ -15,7 +16,7 @@ define( [
 	"./selector/contains",
 	"./selector/escapeSelector"
 ], function( jQuery, nodeName, document, indexOf, hasOwn, pop, push, sort,
-	whitespace, rtrimCSS, support ) {
+	splice, whitespace, rtrimCSS, support ) {
 
 "use strict";
 
@@ -785,7 +786,7 @@ jQuery.uniqueSort = function( results ) {
 			}
 		}
 		while ( j-- ) {
-			results.splice( duplicates[ j ], 1 );
+			splice.call( results, duplicates[ j ], 1 );
 		}
 	}
 
diff --git a/src/var/splice.js b/src/var/splice.js
@@ -0,0 +1,9 @@
+define( [
+	"./arr"
+], function( arr ) {
+
+"use strict";
+
+return arr.splice;
+
+} );
diff --git a/test/unit/selector.js b/test/unit/selector.js
@@ -1887,7 +1887,7 @@ QUnit.test( "jQuery.contains in SVG (jQuery trac-10832)", function( assert ) {
 } );
 
 QUnit.test( "jQuery.uniqueSort", function( assert ) {
-	assert.expect( 15 );
+	assert.expect( 14 );
 
 	function Arrayish( arr ) {
 		var i = this.length = arr.length;
@@ -1896,9 +1896,7 @@ QUnit.test( "jQuery.uniqueSort", function( assert ) {
 		}
 	}
 	Arrayish.prototype = {
-		slice: [].slice,
-		sort: [].sort,
-		splice: [].splice
+		sliceForTestOnly: [].slice
 	};
 
 	var i, tests,
@@ -1960,11 +1958,13 @@ QUnit.test( "jQuery.uniqueSort", function( assert ) {
 
 	jQuery.each( tests, function( label, test ) {
 		var length = test.length || test.input.length;
-		assert.deepEqual( jQuery.uniqueSort( test.input ).slice( 0, length ), test.expected, label + " (array)" );
-		assert.deepEqual( jQuery.uniqueSort( new Arrayish( test.input ) ).slice( 0, length ), test.expected, label + " (quasi-array)" );
+		// We duplicate `test.input` because otherwise it is modified by `uniqueSort`
+		// and the second test becomes worthless.
+		assert.deepEqual( jQuery.uniqueSort( test.input.slice( 0 ) ).slice( 0, length ),
+			test.expected, label + " (array)" );
+		assert.deepEqual( jQuery.uniqueSort( new Arrayish( test.input ) ).sliceForTestOnly( 0, length ),
+			test.expected, label + " (quasi-array)" );
 	} );
-
-	assert.strictEqual( jQuery.unique, jQuery.uniqueSort, "jQuery.unique() is an alias for jQuery.uniqueSort()" );
 } );
 
 testIframe(

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@ define( [`
`7`	`7`	`"./var/pop",`
`8`	`8`	`"./var/push",`
`9`	`9`	`"./var/sort",`
	`10`	`+ "./var/splice",`
`10`	`11`	`"./var/whitespace",`
`11`	`12`	`"./var/rtrimCSS",`
`12`	`13`	`"./var/support",`
`@@ -15,7 +16,7 @@ define( [`
`15`	`16`	`"./selector/contains",`
`16`	`17`	`"./selector/escapeSelector"`
`17`	`18`	`], function( jQuery, nodeName, document, indexOf, hasOwn, pop, push, sort,`
`18`		`- whitespace, rtrimCSS, support ) {`
	`19`	`+ splice, whitespace, rtrimCSS, support ) {`
`19`	`20`
`20`	`21`	`"use strict";`
`21`	`22`
`@@ -785,7 +786,7 @@ jQuery.uniqueSort = function( results ) {`
`785`	`786`	`}`
`786`	`787`	`}`
`787`	`788`	`while ( j-- ) {`
`788`		`- results.splice( duplicates[ j ], 1 );`
	`789`	`+ splice.call( results, duplicates[ j ], 1 );`
`789`	`790`	`}`
`790`	`791`	`}`
`791`	`792`