BUG: fix datetime/timedelta hash memory leak (#29411)

kostayScr · ngoldbaum · web-flow · commit 439f7632ab2a · 2025-07-24T08:59:28.000-06:00
* BUG: fix datetime/timedelta hash memory leak

* get metadata directly from scalar object

Co-authored-by: Nathan Goldbaum &lt;nathan.goldbaum@gmail.com&gt;

* BUG: remove unnecessary Py_DECREF

Co-authored-by: Nathan Goldbaum &lt;nathan.goldbaum@gmail.com&gt;

* BUG: remove dtype variable declaration that is not used anymore

---------

Co-authored-by: Nathan Goldbaum &lt;nathan.goldbaum@gmail.com&gt;
diff --git a/numpy/_core/src/multiarray/scalartypes.c.src b/numpy/_core/src/multiarray/scalartypes.c.src
@@ -3911,18 +3911,17 @@ static npy_hash_t
 @lname@_arrtype_hash(PyObject *obj)
 {
     PyArray_DatetimeMetaData *meta;
-    PyArray_Descr *dtype;
     npy_@lname@ val = PyArrayScalar_VAL(obj, @name@);
 
     if (val == NPY_DATETIME_NAT) {
         /* Use identity, similar to NaN */
         return PyBaseObject_Type.tp_hash(obj);
     }
 
-    dtype = PyArray_DescrFromScalar(obj);
-    meta = get_datetime_metadata_from_dtype(dtype);
+    meta = &((PyDatetimeScalarObject *)obj)->obmeta;
 
-    return @lname@_hash(meta, val);
+    npy_hash_t res = @lname@_hash(meta, val);
+    return res;
 }
 /**end repeat**/
 

Original file line number	Diff line number	Diff line change
`@@ -3911,18 +3911,17 @@ static npy_hash_t`
`3911`	`3911`	`@lname@_arrtype_hash(PyObject *obj)`
`3912`	`3912`	`{`
`3913`	`3913`	`PyArray_DatetimeMetaData *meta;`
`3914`		`- PyArray_Descr *dtype;`
`3915`	`3914`	`npy_@lname@ val = PyArrayScalar_VAL(obj, @name@);`
`3916`	`3915`
`3917`	`3916`	`if (val == NPY_DATETIME_NAT) {`
`3918`	`3917`	`/* Use identity, similar to NaN */`
`3919`	`3918`	`return PyBaseObject_Type.tp_hash(obj);`
`3920`	`3919`	`}`
`3921`	`3920`
`3922`		`- dtype = PyArray_DescrFromScalar(obj);`
`3923`		`- meta = get_datetime_metadata_from_dtype(dtype);`
	`3921`	`+ meta = &((PyDatetimeScalarObject *)obj)->obmeta;`
`3924`	`3922`
`3925`		`- return @lname@_hash(meta, val);`
	`3923`	`+ npy_hash_t res = @lname@_hash(meta, val);`
	`3924`	`+ return res;`
`3926`	`3925`	`}`
`3927`	`3926`	`/end repeat/`
`3928`	`3927`