Don't assume that PageIsEmpty() returns true on an all-zeros page.

hlinnaka · hlinnaka · commit 0e98ad0915ce · 2015-07-27T18:54:30.000+03:00
It does currently, and I don't see us changing that any time soon, but we
don't make that assumption anywhere else.

Per Tom Lane's suggestion. Backpatch to 9.2, like the previous patch that
added this assumption.
diff --git a/src/backend/access/spgist/spgvacuum.c b/src/backend/access/spgist/spgvacuum.c
@@ -652,7 +652,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)
 	 */
 	if (!SpGistBlockIsRoot(blkno))
 	{
-		if (PageIsEmpty(page))
+		if (PageIsNew(page) || PageIsEmpty(page))
 		{
 			RecordFreeIndexPage(index, blkno);
 			bds->stats->pages_deleted++;

Original file line number	Diff line number	Diff line change
`@@ -652,7 +652,7 @@ spgvacuumpage(spgBulkDeleteState *bds, BlockNumber blkno)`
`652`	`652`	`*/`
`653`	`653`	`if (!SpGistBlockIsRoot(blkno))`
`654`	`654`	`{`
`655`		`- if (PageIsEmpty(page))`
	`655`	`+ if (PageIsNew(page) \|\| PageIsEmpty(page))`
`656`	`656`	`{`
`657`	`657`	`RecordFreeIndexPage(index, blkno);`
`658`	`658`	`bds->stats->pages_deleted++;`