Make ecpg's rjulmdy() and rmdyjul() agree with their declarations.

tglsfdc · tglsfdc · commit 1b242f42ba1e · 2021-01-28T11:17:13.000-05:00
We had "short *mdy" in the extern declarations, but "short mdy[3]" in the actual function definitions. Per C99 these are equivalent, but recent versions of gcc have started to issue warnings about the inconsistency. Clean it up before the warnings get any more widespread. Back-patch, in case anyone wants to build older PG versions with bleeding-edge compilers. Discussion: https://postgr.es/m/2401575.1611764534@sss.pgh.pa.us
diff --git a/src/interfaces/ecpg/compatlib/informix.c b/src/interfaces/ecpg/compatlib/informix.c
@@ -513,7 +513,7 @@ rtoday(date * d)
 }
 
 int
-rjulmdy(date d, short mdy[3])
+rjulmdy(date d, short *mdy)
 {
 	int			mdy_int[3];
 
@@ -564,7 +564,7 @@ rfmtdate(date d, const char *fmt, char *str)
 }
 
 int
-rmdyjul(short mdy[3], date * d)
+rmdyjul(short *mdy, date * d)
 {
 	int			mdy_int[3];
 

Original file line number	Diff line number	Diff line change
`@@ -513,7 +513,7 @@ rtoday(date * d)`
`513`	`513`	`}`
`514`	`514`
`515`	`515`	`int`
`516`		`-rjulmdy(date d, short mdy[3])`
	`516`	`+rjulmdy(date d, short *mdy)`
`517`	`517`	`{`
`518`	`518`	`int mdy_int[3];`
`519`	`519`
`@@ -564,7 +564,7 @@ rfmtdate(date d, const char fmt, char str)`
`564`	`564`	`}`
`565`	`565`
`566`	`566`	`int`
`567`		`-rmdyjul(short mdy[3], date * d)`
	`567`	`+rmdyjul(short mdy, date d)`
`568`	`568`	`{`
`569`	`569`	`int mdy_int[3];`
`570`	`570`