Fix pg_dump COMMENT dependency for separate domain constraints.

nmisch · nmisch · commit 4ad846445dd0 · 2025-09-16T09:40:48.000-07:00
The COMMENT should depend on the separately-dumped constraint, not the domain. Sufficient restore parallelism might fail the COMMENT command by issuing it before the constraint exists. Back-patch to v13, like commit 0858f0f. Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de> Discussion: https://postgr.es/m/20250913020233.fa.nmisch@google.com Backpatch-through: 13
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -18634,7 +18634,7 @@ dumpConstraint(Archive *fout, const ConstraintInfo *coninfo)
 				dumpComment(fout, conprefix->data, qtypname,
 							tyinfo->dobj.namespace->dobj.name,
 							tyinfo->rolname,
-							coninfo->dobj.catId, 0, tyinfo->dobj.dumpId);
+							coninfo->dobj.catId, 0, coninfo->dobj.dumpId);
 				destroyPQExpBuffer(conprefix);
 				free(qtypname);
 			}

Original file line number	Diff line number	Diff line change
`@@ -18634,7 +18634,7 @@ dumpConstraint(Archive fout, const ConstraintInfo coninfo)`
`18634`	`18634`	`dumpComment(fout, conprefix->data, qtypname,`
`18635`	`18635`	`tyinfo->dobj.namespace->dobj.name,`
`18636`	`18636`	`tyinfo->rolname,`
`18637`		`- coninfo->dobj.catId, 0, tyinfo->dobj.dumpId);`
	`18637`	`+ coninfo->dobj.catId, 0, coninfo->dobj.dumpId);`
`18638`	`18638`	`destroyPQExpBuffer(conprefix);`
`18639`	`18639`	`free(qtypname);`
`18640`	`18640`	`}`