Track tlist_vinfo.varnullingrels even in non-Assert builds.

tglsfdc · tglsfdc · commit 69c430626b5e · 2023-05-17T11:46:15.000-04:00
Oversight in commit 867be9c (which should get reverted along with that, if we ever do revert it). Per buildfarm.
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c
@@ -42,9 +42,7 @@ typedef struct
 	int			varno;			/* RT index of Var */
 	AttrNumber	varattno;		/* attr number of Var */
 	AttrNumber	resno;			/* TLE position of Var */
-#ifdef USE_ASSERT_CHECKING
 	Bitmapset  *varnullingrels; /* Var's varnullingrels */
-#endif
 } tlist_vinfo;
 
 typedef struct
@@ -2682,9 +2680,7 @@ build_tlist_index(List *tlist)
 			vinfo->varno = var->varno;
 			vinfo->varattno = var->varattno;
 			vinfo->resno = tle->resno;
-#ifdef USE_ASSERT_CHECKING
 			vinfo->varnullingrels = var->varnullingrels;
-#endif
 			vinfo++;
 		}
 		else if (tle->expr && IsA(tle->expr, PlaceHolderVar))
@@ -2737,9 +2733,7 @@ build_tlist_index_other_vars(List *tlist, int ignore_rel)
 				vinfo->varno = var->varno;
 				vinfo->varattno = var->varattno;
 				vinfo->resno = tle->resno;
-#ifdef USE_ASSERT_CHECKING
 				vinfo->varnullingrels = var->varnullingrels;
-#endif
 				vinfo++;
 			}
 		}
