Fix compiler warning

tglsfdc · tglsfdc · commit 98274e8fe7a0 · 2021-12-13T00:24:41.000-05:00
With some newer gcc versions (8 and 9) you get a -Wformat-overflow warning here. In PG11 and later this was already fixed. Since it's trivial, backport it to get the older branches building without warnings. This back-patches commit 333a186 into out-of-support branches, pursuant to newly-established project policy. The point is to suppress scary-looking warnings so that people building these branches needn't expend brain cells verifying that it's safe to ignore the warnings. Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -1490,7 +1490,7 @@ parseQuery(Command *cmd, const char *raw_sql)
 	p = sql;
 	while ((p = strchr(p, ':')) != NULL)
 	{
-		char		var[12];
+		char		var[13];
 		char	   *name;
 		int			eaten;
 

Original file line number	Diff line number	Diff line change
`@@ -1490,7 +1490,7 @@ parseQuery(Command cmd, const char raw_sql)`
`1490`	`1490`	`p = sql;`
`1491`	`1491`	`while ((p = strchr(p, ':')) != NULL)`
`1492`	`1492`	`{`
`1493`		`- char var[12];`
	`1493`	`+ char var[13];`
`1494`	`1494`	`char *name;`
`1495`	`1495`	`int eaten;`
`1496`	`1496`