Use "foo(void)" for definitions of functions with no parameters.

nathan-bossart · nathan-bossart · commit 9b05e2ec08a3 · 2025-12-03T10:54:37.000-06:00
Standard practice in PostgreSQL is to use "foo(void)" instead of "foo()", as the latter looks like an "old-style" function declaration. Similar changes were made in commits cdf4b9a, 0e72b9d, 7069dbc, f1283ed, 7b66e2c, e95126c, and 9f7c527. Author: Bertrand Drouvot <bertranddrouvot.pg@gmail.com> Reviewed-by: Matthias van de Meent <boekewurm+postgres@gmail.com> Discussion: https://postgr.es/m/aTBObQPg%2Bps5I7vl%40ip-10-97-1-34.eu-west-3.compute.internal
diff --git a/src/backend/access/common/heaptuple.c b/src/backend/access/common/heaptuple.c
@@ -123,7 +123,7 @@ missing_match(const void *key1, const void *key2, Size keysize)
 }
 
 static void
-init_missing_cache()
+init_missing_cache(void)
 {
 	HASHCTL		hash_ctl;
 
diff --git a/src/backend/access/index/genam.c b/src/backend/access/index/genam.c
@@ -488,7 +488,7 @@ systable_beginscan(Relation heapRelation,
  * is declared.
  */
 static inline void
-HandleConcurrentAbort()
+HandleConcurrentAbort(void)
 {
 	if (TransactionIdIsValid(CheckXidAlive) &&
 		!TransactionIdIsInProgress(CheckXidAlive) &&
diff --git a/src/backend/replication/logical/applyparallelworker.c b/src/backend/replication/logical/applyparallelworker.c
@@ -640,7 +640,7 @@ pa_detach_all_error_mq(void)
  * Check if there are any pending spooled messages.
  */
 static bool
-pa_has_spooled_message_pending()
+pa_has_spooled_message_pending(void)
 {
 	PartialFileSetState fileset_state;
 
diff --git a/src/backend/replication/logical/sequencesync.c b/src/backend/replication/logical/sequencesync.c
@@ -711,7 +711,7 @@ LogicalRepSyncSequences(void)
  * resource error and are not repeatable.
  */
 static void
-start_sequence_sync()
+start_sequence_sync(void)
 {
 	Assert(am_sequencesync_worker());
 
diff --git a/src/backend/replication/logical/slotsync.c b/src/backend/replication/logical/slotsync.c
@@ -1410,7 +1410,7 @@ check_and_set_sync_info(pid_t worker_pid)
  * Reset syncing flag.
  */
 static void
-reset_syncing_flag()
+reset_syncing_flag(void)
 {
 	SpinLockAcquire(&SlotSyncCtx->mutex);
 	SlotSyncCtx->syncing = false;
diff --git a/src/backend/replication/logical/tablesync.c b/src/backend/replication/logical/tablesync.c
@@ -1551,7 +1551,7 @@ start_table_sync(XLogRecPtr *origin_startpos, char **slotname)
  * and starts streaming to catchup with apply worker.
  */
 static void
-run_tablesync_worker()
+run_tablesync_worker(void)
 {
 	char		originname[NAMEDATALEN];
 	XLogRecPtr	origin_startpos = InvalidXLogRecPtr;
diff --git a/src/backend/replication/logical/worker.c b/src/backend/replication/logical/worker.c
@@ -5561,7 +5561,7 @@ set_stream_options(WalRcvStreamOptions *options,
  * Cleanup the memory for subxacts and reset the related variables.
  */
 static inline void
-cleanup_subxact_info()
+cleanup_subxact_info(void)
 {
 	if (subxact_data.subxacts)
 		pfree(subxact_data.subxacts);
@@ -5621,7 +5621,7 @@ start_apply(XLogRecPtr origin_startpos)
  * It sets up replication origin, streaming options and then starts streaming.
  */
 static void
-run_apply_worker()
+run_apply_worker(void)
 {
 	char		originname[NAMEDATALEN];
 	XLogRecPtr	origin_startpos = InvalidXLogRecPtr;
diff --git a/src/backend/utils/adt/uuid.c b/src/backend/utils/adt/uuid.c
@@ -71,7 +71,7 @@ static int	uuid_fast_cmp(Datum x, Datum y, SortSupport ssup);
 static bool uuid_abbrev_abort(int memtupcount, SortSupport ssup);
 static Datum uuid_abbrev_convert(Datum original, SortSupport ssup);
 static inline void uuid_set_version(pg_uuid_t *uuid, unsigned char version);
-static inline int64 get_real_time_ns_ascending();
+static inline int64 get_real_time_ns_ascending(void);
 static pg_uuid_t *generate_uuidv7(uint64 unix_ts_ms, uint32 sub_ms);
 
 Datum
@@ -545,7 +545,7 @@ gen_random_uuid(PG_FUNCTION_ARGS)
  * than the previous returned timestamp (on this backend).
  */
 static inline int64
-get_real_time_ns_ascending()
+get_real_time_ns_ascending(void)
 {
 	static int64 previous_ns = 0;
 	int64		ns;
diff --git a/src/bin/pg_basebackup/pg_createsubscriber.c b/src/bin/pg_basebackup/pg_createsubscriber.c
@@ -78,7 +78,7 @@ struct LogicalRepInfos
 };
 
 static void cleanup_objects_atexit(void);
-static void usage();
+static void usage(void);
 static char *get_base_conninfo(const char *conninfo, char **dbname);
 static char *get_sub_conninfo(const struct CreateSubscriberOptions *opt);
 static char *get_exec_path(const char *argv0, const char *progname);

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ missing_match(const void key1, const void key2, Size keysize)`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`static void`
`126`		`-init_missing_cache()`
	`126`	`+init_missing_cache(void)`
`127`	`127`	`{`
`128`	`128`	`HASHCTL hash_ctl;`
`129`	`129`
Original file line number	Diff line number	Diff line change
`@@ -488,7 +488,7 @@ systable_beginscan(Relation heapRelation,`
`488`	`488`	`* is declared.`
`489`	`489`	`*/`
`490`	`490`	`static inline void`
`491`		`-HandleConcurrentAbort()`
	`491`	`+HandleConcurrentAbort(void)`
`492`	`492`	`{`
`493`	`493`	`if (TransactionIdIsValid(CheckXidAlive) &&`
`494`	`494`	`!TransactionIdIsInProgress(CheckXidAlive) &&`
Original file line number	Diff line number	Diff line change
`@@ -640,7 +640,7 @@ pa_detach_all_error_mq(void)`
`640`	`640`	`* Check if there are any pending spooled messages.`
`641`	`641`	`*/`
`642`	`642`	`static bool`
`643`		`-pa_has_spooled_message_pending()`
	`643`	`+pa_has_spooled_message_pending(void)`
`644`	`644`	`{`
`645`	`645`	`PartialFileSetState fileset_state;`
`646`	`646`
Original file line number	Diff line number	Diff line change
`@@ -711,7 +711,7 @@ LogicalRepSyncSequences(void)`
`711`	`711`	`* resource error and are not repeatable.`
`712`	`712`	`*/`
`713`	`713`	`static void`
`714`		`-start_sequence_sync()`
	`714`	`+start_sequence_sync(void)`
`715`	`715`	`{`
`716`	`716`	`Assert(am_sequencesync_worker());`
`717`	`717`
Original file line number	Diff line number	Diff line change
`@@ -1410,7 +1410,7 @@ check_and_set_sync_info(pid_t worker_pid)`
`1410`	`1410`	`* Reset syncing flag.`
`1411`	`1411`	`*/`
`1412`	`1412`	`static void`
`1413`		`-reset_syncing_flag()`
	`1413`	`+reset_syncing_flag(void)`
`1414`	`1414`	`{`
`1415`	`1415`	`SpinLockAcquire(&SlotSyncCtx->mutex);`
`1416`	`1416`	`SlotSyncCtx->syncing = false;`
Original file line number	Diff line number	Diff line change
`@@ -1551,7 +1551,7 @@ start_table_sync(XLogRecPtr origin_startpos, char *slotname)`
`1551`	`1551`	`* and starts streaming to catchup with apply worker.`
`1552`	`1552`	`*/`
`1553`	`1553`	`static void`
`1554`		`-run_tablesync_worker()`
	`1554`	`+run_tablesync_worker(void)`
`1555`	`1555`	`{`
`1556`	`1556`	`char originname[NAMEDATALEN];`
`1557`	`1557`	`XLogRecPtr origin_startpos = InvalidXLogRecPtr;`