Fix wrong construct_array_builtin() call in GUCArrayDelete()

akorotkov · akorotkov · commit db93e739ac61 · 2023-04-27T22:06:14.000+03:00
The current code unintentionally uses the wrong datum to construct an array. The bug was introduced by 096dd80, so no backpatching is needed. Reported-by: David Steele Discussion: https://postgr.es/m/d46f9265-ff3c-6743-2278-6772598233c2%40pgmasters.net Author: Nathan Bossart Reviewed-by: David Steele, Tom Lane
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
@@ -6496,7 +6496,8 @@ GUCArrayDelete(ArrayType *array, ArrayType **usersetArray, const char *name)
 		{
 			newarray = construct_array_builtin(&d, 1, TEXTOID);
 			if (usersetArray)
-				newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);
+				newUsersetArray = construct_array_builtin(&userSetDatum, 1,
+														  BOOLOID);
 		}
 
 		index++;

Original file line number	Diff line number	Diff line change
`@@ -6496,7 +6496,8 @@ GUCArrayDelete(ArrayType array, ArrayType usersetArray, const char name)`
`6496`	`6496`	`{`
`6497`	`6497`	`newarray = construct_array_builtin(&d, 1, TEXTOID);`
`6498`	`6498`	`if (usersetArray)`
`6499`		`- newUsersetArray = construct_array_builtin(&d, 1, BOOLOID);`
	`6499`	`+ newUsersetArray = construct_array_builtin(&userSetDatum, 1,`
	`6500`	`+ BOOLOID);`
`6500`	`6501`	`}`
`6501`	`6502`
`6502`	`6503`	`index++;`