Fix incorrect const qualifier

petere · petere · commit e179115dc041 · 2025-09-16T07:23:50.000+02:00
Commit 7202d72 added in passing some const qualifiers, but the one on the postmaster_child_launch() startup_data argument was incorrect, because the function itself modifies the pointed-to data. This is hidden from the compiler because of casts. The qualifiers on the functions called by postmaster_child_launch() are still correct.
diff --git a/src/backend/postmaster/launch_backend.c b/src/backend/postmaster/launch_backend.c
@@ -227,7 +227,7 @@ PostmasterChildName(BackendType child_type)
  */
 pid_t
 postmaster_child_launch(BackendType child_type, int child_slot,
-						const void *startup_data, size_t startup_data_len,
+						void *startup_data, size_t startup_data_len,
 						ClientSocket *client_sock)
 {
 	pid_t		pid;
diff --git a/src/include/postmaster/postmaster.h b/src/include/postmaster/postmaster.h
@@ -108,7 +108,7 @@ extern PGDLLIMPORT struct ClientSocket *MyClientSocket;
 /* prototypes for functions in launch_backend.c */
 extern pid_t postmaster_child_launch(BackendType child_type,
 									 int child_slot,
-									 const void *startup_data,
+									 void *startup_data,
 									 size_t startup_data_len,
 									 struct ClientSocket *client_sock);
 const char *PostmasterChildName(BackendType child_type);

Original file line number	Diff line number	Diff line change
`@@ -227,7 +227,7 @@ PostmasterChildName(BackendType child_type)`
`227`	`227`	`*/`
`228`	`228`	`pid_t`
`229`	`229`	`postmaster_child_launch(BackendType child_type, int child_slot,`
`230`		`- const void *startup_data, size_t startup_data_len,`
	`230`	`+ void *startup_data, size_t startup_data_len,`
`231`	`231`	`ClientSocket *client_sock)`
`232`	`232`	`{`
`233`	`233`	`pid_t pid;`