fix(cli): require connection details for init

Nik Samokhvalov · Nik Samokhvalov · commit 4a6066b42e34 · 2025-12-13T11:06:05.000-08:00
- Do not treat PGPASSWORD alone as a valid connection

- Add regression test for missing connection
diff --git a/cli/lib/init.ts b/cli/lib/init.ts
@@ -189,8 +189,9 @@ export function resolveAdminConnection(opts: {
   const conn = (opts.conn || "").trim();
   const dbUrlFlag = (opts.dbUrlFlag || "").trim();
 
-  const hasPsqlParts =
-    !!(opts.host || opts.port || opts.username || opts.dbname || opts.adminPassword || opts.envPassword);
+  // NOTE: passwords alone (PGPASSWORD / --admin-password) do NOT constitute a connection.
+  // We require at least some connection addressing (host/port/user/db) if no positional arg / --db-url is provided.
+  const hasConnDetails = !!(opts.host || opts.port || opts.username || opts.dbname);
 
   if (conn && dbUrlFlag) {
     throw new Error("Provide either positional connection string or --db-url, not both");
@@ -207,7 +208,7 @@ export function resolveAdminConnection(opts: {
     return { clientConfig: cfg, display: describePgConfig(cfg) };
   }
 
-  if (!hasPsqlParts) {
+  if (!hasConnDetails) {
     throw new Error(
       [
         "Connection is required.",
diff --git a/cli/test/init.test.cjs b/cli/test/init.test.cjs
@@ -91,6 +91,10 @@ test("resolveAdminConnection rejects invalid psql-like port", () => {
   );
 });
 
+test("resolveAdminConnection rejects when only PGPASSWORD is provided (no connection details)", () => {
+  assert.throws(() => init.resolveAdminConnection({ envPassword: "pw" }), /Connection is required/);
+});
+
 test("print-sql redaction regex matches password literal with embedded quotes", async () => {
   const plan = await init.buildInitPlan({
     database: "mydb",
