Add noreturn attributes to some error reporting functions

petere · petere · commit 0cb1fac3b19f · 2013-02-12T07:13:22.000-05:00
diff --git a/contrib/cube/cubescan.l b/contrib/cube/cubescan.l
@@ -60,7 +60,7 @@ float        ({integer}|{real})([eE]{integer})?
 
 %%
 
-void
+void __attribute__((noreturn))
 yyerror(const char *message)
 {
 	if (*yytext == YY_END_OF_BUFFER_CHAR)
diff --git a/contrib/seg/segscan.l b/contrib/seg/segscan.l
@@ -59,7 +59,7 @@ float        ({integer}|{real})([eE]{integer})?
 
 %%
 
-void
+void __attribute__((noreturn))
 yyerror(const char *message)
 {
 	if (*yytext == YY_END_OF_BUFFER_CHAR)
diff --git a/src/backend/replication/repl_scanner.l b/src/backend/replication/repl_scanner.l
@@ -152,7 +152,7 @@ addlitchar(unsigned char ychar)
 	appendStringInfoChar(&litbuf, ychar);
 }
 
-void
+void __attribute__((noreturn))
 yyerror(const char *message)
 {
 	ereport(ERROR,
diff --git a/src/include/mb/pg_wchar.h b/src/include/mb/pg_wchar.h
@@ -516,9 +516,9 @@ extern void check_encoding_conversion_args(int src_encoding,
 							   int expected_src_encoding,
 							   int expected_dest_encoding);
 
-extern void report_invalid_encoding(int encoding, const char *mbstr, int len);
+extern void report_invalid_encoding(int encoding, const char *mbstr, int len) __attribute__((noreturn));
 extern void report_untranslatable_char(int src_encoding, int dest_encoding,
-						   const char *mbstr, int len);
+						   const char *mbstr, int len) __attribute__((noreturn));
 
 extern void pg_ascii2mic(const unsigned char *l, unsigned char *p, int len);
 extern void pg_mic2ascii(const unsigned char *mic, unsigned char *p, int len);
diff --git a/src/include/parser/parse_relation.h b/src/include/parser/parse_relation.h
@@ -84,9 +84,9 @@ extern bool isLockedRefname(ParseState *pstate, const char *refname);
 extern void addRTEtoQuery(ParseState *pstate, RangeTblEntry *rte,
 			  bool addToJoinList,
 			  bool addToRelNameSpace, bool addToVarNameSpace);
-extern void errorMissingRTE(ParseState *pstate, RangeVar *relation);
+extern void errorMissingRTE(ParseState *pstate, RangeVar *relation) __attribute__((noreturn));
 extern void errorMissingColumn(ParseState *pstate,
-				   char *relname, char *colname, int location);
+				   char *relname, char *colname, int location) __attribute__((noreturn));
 extern void expandRTE(RangeTblEntry *rte, int rtindex, int sublevels_up,
 		  int location, bool include_dropped,
 		  List **colnames, List **colvars);
diff --git a/src/include/storage/lock.h b/src/include/storage/lock.h
@@ -533,7 +533,7 @@ extern void lock_twophase_standby_recover(TransactionId xid, uint16 info,
 
 extern DeadLockState DeadLockCheck(PGPROC *proc);
 extern PGPROC *GetBlockingAutoVacuumPgproc(void);
-extern void DeadLockReport(void);
+extern void DeadLockReport(void) __attribute__((noreturn));
 extern void RememberSimpleDeadLock(PGPROC *proc1,
 					   LOCKMODE lockmode,
 					   LOCK *lock,
diff --git a/src/include/tcop/tcopprot.h b/src/include/tcop/tcopprot.h
@@ -64,7 +64,7 @@ extern void assign_max_stack_depth(int newval, void *extra);
 extern void die(SIGNAL_ARGS);
 extern void quickdie(SIGNAL_ARGS) __attribute__((noreturn));
 extern void StatementCancelHandler(SIGNAL_ARGS);
-extern void FloatExceptionHandler(SIGNAL_ARGS);
+extern void FloatExceptionHandler(SIGNAL_ARGS) __attribute__((noreturn));
 extern void RecoveryConflictInterrupt(ProcSignalReason reason); /* called from SIGUSR1
 																 * handler */
 extern void prepare_for_client_read(void);
diff --git a/src/pl/plpgsql/src/pl_scanner.c b/src/pl/plpgsql/src/pl_scanner.c
@@ -528,7 +528,7 @@ plpgsql_scanner_errposition(int location)
  * Beware of using yyerror for other purposes, as the cursor position might
  * be misleading!
  */
-void
+void __attribute__((noreturn))
 plpgsql_yyerror(const char *message)
 {
 	char	   *yytext = core_yy.scanbuf + plpgsql_yylloc;

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ float ({integer}\|{real})([eE]{integer})?`
`60`	`60`
`61`	`61`	`%%`
`62`	`62`
`63`		`-void`
	`63`	`+void __attribute__((noreturn))`
`64`	`64`	`yyerror(const char *message)`
`65`	`65`	`{`
`66`	`66`	`if (*yytext == YY_END_OF_BUFFER_CHAR)`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ float ({integer}\|{real})([eE]{integer})?`
`59`	`59`
`60`	`60`	`%%`
`61`	`61`
`62`		`-void`
	`62`	`+void __attribute__((noreturn))`
`63`	`63`	`yyerror(const char *message)`
`64`	`64`	`{`
`65`	`65`	`if (*yytext == YY_END_OF_BUFFER_CHAR)`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ addlitchar(unsigned char ychar)`
`152`	`152`	`appendStringInfoChar(&litbuf, ychar);`
`153`	`153`	`}`
`154`	`154`
`155`		`-void`
	`155`	`+void __attribute__((noreturn))`
`156`	`156`	`yyerror(const char *message)`
`157`	`157`	`{`
`158`	`158`	`ereport(ERROR,`
Original file line number	Diff line number	Diff line change
`@@ -528,7 +528,7 @@ plpgsql_scanner_errposition(int location)`
`528`	`528`	`* Beware of using yyerror for other purposes, as the cursor position might`
`529`	`529`	`* be misleading!`
`530`	`530`	`*/`
`531`		`-void`
	`531`	`+void __attribute__((noreturn))`
`532`	`532`	`plpgsql_yyerror(const char *message)`
`533`	`533`	`{`
`534`	`534`	`char *yytext = core_yy.scanbuf + plpgsql_yylloc;`