Remove unnecessary (char *) casts [checksum]

petere · petere · commit 1b5841d46150 · 2025-02-12T08:59:48.000+01:00
Remove some (char *) casts related to uses of the pg_checksum_page() function. These casts are useless, because everything involved already has the right type. Moreover, these casts actually silently discarded a const qualifier. The declaration of a higher-level function needs to be adjusted to fix that. Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> Discussion: https://www.postgresql.org/message-id/flat/fd1fcedb-3492-4fc8-9e3e-74b97f2db6c7%40eisentraut.org
diff --git a/contrib/pageinspect/rawpage.c b/contrib/pageinspect/rawpage.c
@@ -357,7 +357,7 @@ page_checksum_internal(PG_FUNCTION_ARGS, enum pageinspect_version ext_version)
 	if (PageIsNew(page))
 		PG_RETURN_NULL();
 
-	PG_RETURN_INT16(pg_checksum_page((char *) page, blkno));
+	PG_RETURN_INT16(pg_checksum_page(page, blkno));
 }
 
 Datum
diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c
@@ -85,7 +85,7 @@ PageInit(Page page, Size pageSize, Size specialSize)
  * to pgstat.
  */
 bool
-PageIsVerifiedExtended(const PageData *page, BlockNumber blkno, int flags)
+PageIsVerifiedExtended(PageData *page, BlockNumber blkno, int flags)
 {
 	const PageHeaderData *p = (const PageHeaderData *) page;
 	size_t	   *pagebytes;
@@ -100,7 +100,7 @@ PageIsVerifiedExtended(const PageData *page, BlockNumber blkno, int flags)
 	{
 		if (DataChecksumsEnabled())
 		{
-			checksum = pg_checksum_page((char *) page, blkno);
+			checksum = pg_checksum_page(page, blkno);
 
 			if (checksum != p->pd_checksum)
 				checksum_failure = true;
@@ -1534,5 +1534,5 @@ PageSetChecksumInplace(Page page, BlockNumber blkno)
 	if (PageIsNew(page) || !DataChecksumsEnabled())
 		return;
 
-	((PageHeader) page)->pd_checksum = pg_checksum_page((char *) page, blkno);
+	((PageHeader) page)->pd_checksum = pg_checksum_page(page, blkno);
 }
diff --git a/src/include/storage/bufpage.h b/src/include/storage/bufpage.h
@@ -489,7 +489,7 @@ StaticAssertDecl(BLCKSZ == ((BLCKSZ / sizeof(size_t)) * sizeof(size_t)),
 				 "BLCKSZ has to be a multiple of sizeof(size_t)");
 
 extern void PageInit(Page page, Size pageSize, Size specialSize);
-extern bool PageIsVerifiedExtended(const PageData *page, BlockNumber blkno, int flags);
+extern bool PageIsVerifiedExtended(PageData *page, BlockNumber blkno, int flags);
 extern OffsetNumber PageAddItemExtended(Page page, Item item, Size size,
 										OffsetNumber offsetNumber, int flags);
 extern Page PageGetTempPage(const PageData *page);

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ page_checksum_internal(PG_FUNCTION_ARGS, enum pageinspect_version ext_version)`
`357`	`357`	`if (PageIsNew(page))`
`358`	`358`	`PG_RETURN_NULL();`
`359`	`359`
`360`		`- PG_RETURN_INT16(pg_checksum_page((char *) page, blkno));`
	`360`	`+ PG_RETURN_INT16(pg_checksum_page(page, blkno));`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`Datum`
Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ PageInit(Page page, Size pageSize, Size specialSize)`
`85`	`85`	`* to pgstat.`
`86`	`86`	`*/`
`87`	`87`	`bool`
`88`		`-PageIsVerifiedExtended(const PageData *page, BlockNumber blkno, int flags)`
	`88`	`+PageIsVerifiedExtended(PageData *page, BlockNumber blkno, int flags)`
`89`	`89`	`{`
`90`	`90`	`const PageHeaderData p = (const PageHeaderData ) page;`
`91`	`91`	`size_t *pagebytes;`
`@@ -100,7 +100,7 @@ PageIsVerifiedExtended(const PageData *page, BlockNumber blkno, int flags)`
`100`	`100`	`{`
`101`	`101`	`if (DataChecksumsEnabled())`
`102`	`102`	`{`
`103`		`- checksum = pg_checksum_page((char *) page, blkno);`
	`103`	`+ checksum = pg_checksum_page(page, blkno);`
`104`	`104`
`105`	`105`	`if (checksum != p->pd_checksum)`
`106`	`106`	`checksum_failure = true;`
`@@ -1534,5 +1534,5 @@ PageSetChecksumInplace(Page page, BlockNumber blkno)`
`1534`	`1534`	`if (PageIsNew(page) \|\| !DataChecksumsEnabled())`
`1535`	`1535`	`return;`
`1536`	`1536`
`1537`		`- ((PageHeader) page)->pd_checksum = pg_checksum_page((char *) page, blkno);`
	`1537`	`+ ((PageHeader) page)->pd_checksum = pg_checksum_page(page, blkno);`
`1538`	`1538`	`}`