Release temporary array in check_for_data_types_usage().

tglsfdc · tglsfdc · commit 225e1dde463a · 2024-03-24T12:13:35.000-04:00
Coverity identified this as a resource leak. It's surely of no consequence given that the function is called only once per run, but freeing the storage is no more work than dismissing the complaint. Minor oversight in commit 347758b.
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
@@ -521,6 +521,8 @@ check_for_data_types_usage(ClusterInfo *cluster, DataTypesUsageChecks * checks)
 	if (found)
 		pg_fatal("Data type checks failed: %s", report.data);
 
+	pg_free(results);
+
 	check_ok();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -521,6 +521,8 @@ check_for_data_types_usage(ClusterInfo cluster, DataTypesUsageChecks checks)`
`521`	`521`	`if (found)`
`522`	`522`	`pg_fatal("Data type checks failed: %s", report.data);`
`523`	`523`
	`524`	`+ pg_free(results);`
	`525`	`+`
`524`	`526`	`check_ok();`
`525`	`527`	`}`
`526`	`528`