Don't treat DumpOptions->dump_inserts like a boolean

alvherre · alvherre · commit 2661a793ff59 · 2020-07-08T14:54:46.000-04:00
This has been an integer count since 7e413a0 so treat it explicitly like an integer. No backpatch since this is just cosmetic.
diff --git a/src/bin/pg_dump/pg_backup.h b/src/bin/pg_dump/pg_backup.h
@@ -71,7 +71,7 @@ typedef struct _restoreOptions
 	char	   *use_role;		/* Issue SET ROLE to this */
 	int			dropSchema;
 	int			disable_dollar_quoting;
-	int			dump_inserts;
+	int			dump_inserts;	/* 0 = COPY, otherwise rows per INSERT */
 	int			column_inserts;
 	int			if_exists;
 	int			no_comments;	/* Skip comments */
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -2254,7 +2254,7 @@ dumpTableData(Archive *fout, TableDataInfo *tdinfo)
 	char	   *copyStmt;
 	const char *copyFrom;
 
-	if (!dopt->dump_inserts)
+	if (dopt->dump_inserts == 0)
 	{
 		/* Dump/restore using COPY */
 		dumpFn = dumpTableData_copy;

Original file line number	Diff line number	Diff line change
`@@ -2254,7 +2254,7 @@ dumpTableData(Archive fout, TableDataInfo tdinfo)`
`2254`	`2254`	`char *copyStmt;`
`2255`	`2255`	`const char *copyFrom;`
`2256`	`2256`
`2257`		`- if (!dopt->dump_inserts)`
	`2257`	`+ if (dopt->dump_inserts == 0)`
`2258`	`2258`	`{`
`2259`	`2259`	`/* Dump/restore using COPY */`
`2260`	`2260`	`dumpFn = dumpTableData_copy;`