Fix harmless LC_COLLATE[_MASK] confusion.

macdice · macdice · commit 2724ff381a16 · 2024-08-19T22:12:55.000+12:00
Commit ca051d8 called newlocale(LC_COLLATE, ...) instead of newlocale(LC_COLLATE_MASK, ...), in code reached only on FreeBSD. They have the same value on that OS, explaining why it worked. Fix. Back-patch to 14, where ca051d8 landed.
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
@@ -1755,7 +1755,7 @@ get_collation_actual_version(char collprovider, const char *collcollate)
 		locale_t	loc;
 
 		/* Look up FreeBSD collation version. */
-		loc = newlocale(LC_COLLATE, collcollate, NULL);
+		loc = newlocale(LC_COLLATE_MASK, collcollate, NULL);
 		if (loc)
 		{
 			collversion =

Original file line number	Diff line number	Diff line change
`@@ -1755,7 +1755,7 @@ get_collation_actual_version(char collprovider, const char *collcollate)`
`1755`	`1755`	`locale_t loc;`
`1756`	`1756`
`1757`	`1757`	`/* Look up FreeBSD collation version. */`
`1758`		`- loc = newlocale(LC_COLLATE, collcollate, NULL);`
	`1758`	`+ loc = newlocale(LC_COLLATE_MASK, collcollate, NULL);`
`1759`	`1759`	`if (loc)`
`1760`	`1760`	`{`
`1761`	`1761`	`collversion =`