Fix MSVC warning introduced in ea1db8a.

jeff-davis · jeff-davis · commit 36320cbc164a · 2023-04-04T15:43:18.000-07:00
Discussion: https://postgr.es/m/CA+hUKGJR1BhCORa5WdvwxztD3arhENcwaN1zEQ1Upg20BwjKWA@mail.gmail.com Reported-by: Thomas Munro
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
@@ -2908,6 +2908,7 @@ icu_language_tag(const char *loc_str, int elevel)
 	ereport(ERROR,
 			(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
 			 errmsg("ICU is not supported in this build")));
+	return NULL;		/* keep compiler quiet */
 #endif							/* not USE_ICU */
 }
 
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -2298,6 +2298,7 @@ icu_language_tag(const char *loc_str)
 	return langtag;
 #else
 	pg_fatal("ICU is not supported in this build");
+	return NULL;		/* keep compiler quiet */
 #endif
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2908,6 +2908,7 @@ icu_language_tag(const char *loc_str, int elevel)`
`2908`	`2908`	`ereport(ERROR,`
`2909`	`2909`	`(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
`2910`	`2910`	`errmsg("ICU is not supported in this build")));`
	`2911`	`+ return NULL; /* keep compiler quiet */`
`2911`	`2912`	`#endif /* not USE_ICU */`
`2912`	`2913`	`}`
`2913`	`2914`
Original file line number	Diff line number	Diff line change
`@@ -2298,6 +2298,7 @@ icu_language_tag(const char *loc_str)`
`2298`	`2298`	`return langtag;`
`2299`	`2299`	`#else`
`2300`	`2300`	`pg_fatal("ICU is not supported in this build");`
	`2301`	`+ return NULL; /* keep compiler quiet */`
`2301`	`2302`	`#endif`
`2302`	`2303`	`}`
`2303`	`2304`