Fix timing issue in pg_rewind test.

hlinnaka · hlinnaka · commit 39f9f04b5784 · 2020-11-15T17:09:31.000+02:00
The test inserts a row in primary server, waits until the insertion has been replicated to a cascaded standby, and checks that it's visible there by querying the cascaded standby. In order for that to work reliably, the test needs to wait until the insertion WAL record has been fully replayed. This should fix the occasional buildfarm failures. Diagnosis by Tom Lane. Discussion: https://www.postgresql.org/message-id/606796.1605424022@sss.pgh.pa.us
diff --git a/src/bin/pg_rewind/t/007_standby_source.pl b/src/bin/pg_rewind/t/007_standby_source.pl
@@ -155,7 +155,7 @@
 	"INSERT INTO tbl1 values ('in A, after rewind')");
 
 $lsn = $node_a->lsn('insert');
-$node_b->wait_for_catchup('node_c', 'write', $lsn);
+$node_b->wait_for_catchup('node_c', 'replay', $lsn);
 
 check_query(
 	'SELECT * FROM tbl1',
