Fix check for memory allocation

danielgustafsson · danielgustafsson · commit 4013a5ada252 · 2024-05-27T19:37:17.000+02:00
Commit 61461a3 accidentally checked memory allocation success using the wrong variable. Author: Ranier Vilela <ranier.vf@gmail.com> Reviewed-by: Jelte Fennema-Nio <postgres@jeltef.nl> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/CAEudQAqQFTH7xCB-+K6zEKjfqbhqCxcr_w4DuJTxVT6h3vzu2w@mail.gmail.com
diff --git a/src/interfaces/libpq/fe-cancel.c b/src/interfaces/libpq/fe-cancel.c
@@ -145,7 +145,7 @@ PQcancelCreate(PGconn *conn)
 	}
 
 	cancelConn->addr = calloc(cancelConn->naddr, sizeof(AddrInfo));
-	if (!cancelConn->connhost)
+	if (!cancelConn->addr)
 		goto oom_error;
 
 	cancelConn->addr[0].addr = conn->raddr;

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ PQcancelCreate(PGconn *conn)`
`145`	`145`	`}`
`146`	`146`
`147`	`147`	`cancelConn->addr = calloc(cancelConn->naddr, sizeof(AddrInfo));`
`148`		`- if (!cancelConn->connhost)`
	`148`	`+ if (!cancelConn->addr)`
`149`	`149`	`goto oom_error;`
`150`	`150`
`151`	`151`	`cancelConn->addr[0].addr = conn->raddr;`